[Lens] Init scout and add `should display ES|QL conversion modal` test by mariairiartef · Pull Request #249819 · elastic/kibana

mariairiartef · 2026-01-21T07:33:46Z

Summary

Close #250383
Close #250384

Init scout in Lens
Add switchToEditMode and openInLineEditor to the dashboard app
Create lens app and add the following methods:
- getConvertToEsqlButton
- getConvertToEsqModal
- getConvertToEsqModalConfirmButton
Add should display ES|QL conversion modal test

For the test, we have used the LOGSTASH ES archive.

Note

The complete conversion flow will be tested in a separate PR, once #248078 is merged.

How to run the tests

Run server:

node scripts/scout.js start-server --stateful

In a separate terminal, run tests:

npx playwright test --project local --grep @ess --config x-pack/platform/plugins/shared/lens/test/scout/ui/  --ui

Checklist

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

x-pack/platform/plugins/shared/lens/test/scout/ui/fixtures/esql_conversion_dashboard.json

elasticmachine · 2026-01-26T14:20:07Z

Pinging @elastic/kibana-visualizations (Team:Visualizations)

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/dashboard_app.ts

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/lens_app.ts

nickofthyme

Very nice! Super excited for this 🎉

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/dashboard_app.ts

...tform/plugins/shared/lens/public/app_plugin/shared/edit_on_the_fly/convert_to_esql_modal.tsx

csr · 2026-02-03T09:37:48Z

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/lens_app.ts

+
+import type { ScoutPage } from '..';
+
+export class LensApp {


Hey! Just a heads up, my PR #249233 is also adding a Lens object. Expect to see some changes in this page object if my PR is merged after yours (I'm hoping that's the case so you don't have to go through merge conflict resolution).

dmlemeshko · 2026-02-03T09:53:19Z

x-pack/platform/plugins/shared/lens/readme.md

  - Run `node ../scripts/functional_test_runner.js --config ./test/api_integration/config.ts --grep=Lens`
 - Performance journeys:
  - Run `node scripts/run_performance --journey-path x-pack/performance/journeys_e2e/data_stress_test_lens`
+  - Run `node scripts/run_performance --journey-path x-pack/performance/journeys_e2e/data_stress_test_lens_http2`     


I don't see a journey being added in this PR. Was it intentional?

I think it was added automatically, 🤔 removed here

dmlemeshko · 2026-02-03T09:54:28Z

x-pack/platform/plugins/shared/lens/test/scout/ui/playwright.config.ts

+export default createPlaywrightConfig({
+  testDir: './tests',
+});


Since Lens support Spaces, is it possible to consider running tests in space isolation and in parallel? It will be ~30-40% faster based on current metrics.

dmlemeshko · 2026-02-03T09:55:18Z

x-pack/platform/plugins/shared/lens/test/scout/ui/tests/esql_conversion.spec.ts

+
+// Unskip after: https://github.com/elastic/kibana-team/issues/2740
+// eslint-disable-next-line playwright/no-skipped-test
+test.describe.skip('Lens ES|QL', { tag: ['@ess'] }, () => {


I guess there is no point in flaky-test-runner since test suite is skipped...

I unskipped the test and run the flaky-test-runner. The stats are here, thanks!

dmlemeshko

LGTM, left few nits

kibanamachine · 2026-02-03T10:04:35Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#10645

[✅] x-pack/platform/plugins/shared/lens/test/scout/ui/playwright.config.ts: 25/25 tests passed.

see run history

kibanamachine · 2026-02-04T11:03:29Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#10651

[✅] x-pack/platform/plugins/shared/lens/test/scout/ui/playwright.config.ts: 15/15 tests passed.

see run history

elasticmachine · 2026-02-04T14:29:04Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: f53a308

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #53 / Endpoint plugin @ess @serverless @skipInServerlessMKI When attempting to call an endpoint api "before all" hook in "@ess @serverless @skipInServerlessMKI When attempting to call an endpoint api"
[job] [logs] Scout: [ platform / streams_app-serverless-oblt ] plugin / serverless-oblt - Stream data processing - data sources management - should allow adding a new kql data source
[job] [logs] Scout: [ platform / streams_app-serverless-oblt ] plugin / serverless-oblt - Stream data processing - data sources management - should allow adding a new kql data source
[job] [logs] Scout: [ platform / streams_app-stateful ] plugin / should allow adding a new kql data source
[job] [logs] Scout: [ platform / streams_app-serverless-oblt ] plugin / should allow adding a new kql data source
[job] [logs] Scout: [ platform / streams_app-stateful ] plugin / should allow adding a new kql data source
[job] [logs] Scout: [ platform / streams_app-serverless-oblt ] plugin / should allow adding a new kql data source
[job] [logs] Scout: [ platform / streams_app-stateful ] plugin / stateful - Stream data processing - data sources management - should allow adding a new kql data source
[job] [logs] Scout: [ platform / streams_app-stateful ] plugin / stateful - Stream data processing - data sources management - should allow adding a new kql data source

History

💔 Build #389740 failed 309aec8
💛 Build #389120 was flaky a74e3b4
💔 Build #386484 failed e93e84f
💔 Build #386332 failed a2fc983
💔 Build #386101 failed d95df24

cc @mariairiartef

mariairiartef added 2 commits January 20, 2026 10:12

[Lens] Init scout

29857d9

[Lens] Add initial test fixtures and tests for Lens functionality

b0d1874

mariairiartef force-pushed the lens/init-scout branch from d1fce81 to b0d1874 Compare January 21, 2026 13:55

Add test dashboard

ff30b78

mariairiartef force-pushed the lens/init-scout branch 2 times, most recently from ddd0009 to d500ee0 Compare January 26, 2026 11:13

Merge branch 'main' into lens/init-scout

a0a41c3

mariairiartef force-pushed the lens/init-scout branch from d500ee0 to a0a41c3 Compare January 26, 2026 11:17

mariairiartef changed the title ~~[Lens] Init scout~~ [Lens] Init scout and add should display ES|QL conversion modal test Jan 26, 2026

mariairiartef self-assigned this Jan 26, 2026

mariairiartef added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This PR does not require backporting labels Jan 26, 2026

Add dashboard app methods: switchToEditMode and openInLineEditor

9c505ea

mariairiartef force-pushed the lens/init-scout branch from d905d03 to 9c505ea Compare January 26, 2026 14:12

mariairiartef commented Jan 26, 2026

View reviewed changes

x-pack/platform/plugins/shared/lens/test/scout/ui/fixtures/esql_conversion_dashboard.json Show resolved Hide resolved

mariairiartef added the test:scout label Jan 26, 2026

mariairiartef marked this pull request as ready for review January 26, 2026 14:20

mariairiartef requested review from a team as code owners January 26, 2026 14:20

Changes from node scripts/lint_ts_projects --fix

ba56fa7

mariairiartef mentioned this pull request Jan 26, 2026

[Lens powered by ES|QL] Testing: add ES|QL conversion assertions #250385

Open

mariairiartef added 2 commits January 26, 2026 17:26

Fix eslint issue

d95df24

Fix typo

a2fc983

mariairiartef force-pushed the lens/init-scout branch from e07355b to 2b9c81e Compare January 27, 2026 14:03

Update readme file

e93e84f

mariairiartef force-pushed the lens/init-scout branch from 2b9c81e to e93e84f Compare January 27, 2026 14:04

dmlemeshko reviewed Jan 27, 2026

View reviewed changes

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/dashboard_app.ts Outdated Show resolved Hide resolved

dmlemeshko reviewed Jan 27, 2026

View reviewed changes

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/lens_app.ts Show resolved Hide resolved

nickofthyme approved these changes Jan 27, 2026

View reviewed changes

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/dashboard_app.ts Outdated Show resolved Hide resolved

mariairiartef and others added 5 commits January 29, 2026 16:08

Remove unnecessary wait for edit button visibility in DashboardApp

8a414ac

Move LensApp to share page objects folder

7cc9b0e

Update openInlineEditor method name

a9081a2

Skip Lens ES|QL test until issue 2740 is resolved

ff7897c

Merge branch 'main' into lens/init-scout

0988a18

mariairiartef requested a review from dmlemeshko January 29, 2026 15:33

walterra reviewed Jan 29, 2026

View reviewed changes

...tform/plugins/shared/lens/public/app_plugin/shared/edit_on_the_fly/convert_to_esql_modal.tsx Outdated Show resolved Hide resolved

Fix typo

5a78469

mariairiartef requested a review from walterra February 3, 2026 09:17

Merge branch 'main' into lens/init-scout

a74e3b4

csr reviewed Feb 3, 2026

View reviewed changes

dmlemeshko reviewed Feb 3, 2026

View reviewed changes

dmlemeshko approved these changes Feb 3, 2026

View reviewed changes

walterra approved these changes Feb 4, 2026

View reviewed changes

mariairiartef and others added 3 commits February 4, 2026 11:17

Unskip test and set feature flag via core plugin api

6775615

Remove journey

c2b5f5d

Merge branch 'main' into lens/init-scout

309aec8

mariairiartef enabled auto-merge (squash) February 4, 2026 12:39

Merge branch 'main' into lens/init-scout

f53a308

Merge branch 'main' into lens/init-scout

c026ca7

mariairiartef merged commit b870e77 into elastic:main Feb 4, 2026
16 checks passed

kibanamachine added the v9.4.0 label Feb 4, 2026

Conversation

mariairiartef commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to run the tests

Checklist

Uh oh!

Uh oh!

elasticmachine commented Jan 26, 2026

Uh oh!

Uh oh!

Uh oh!

nickofthyme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

csr Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

mariairiartef Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mariairiartef Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 3, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#10645

Uh oh!

kibanamachine commented Feb 4, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#10651

Uh oh!

elasticmachine commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mariairiartef commented Jan 21, 2026 •

edited

Loading

csr Feb 3, 2026 •

edited

Loading

dmlemeshko Feb 3, 2026 •

edited

Loading

elasticmachine commented Feb 4, 2026 •

edited

Loading