[App Menu Standardization] Handle subitems popover test id#249182
Merged
kowalczyk-krzysztof merged 3 commits intoelastic:mainfrom Jan 15, 2026
Merged
Conversation
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
091e28d to
5d2f978
Compare
Dosant
approved these changes
Jan 15, 2026
| @@ -46,7 +46,9 @@ export const AppMenuPopover = ({ | |||
| onClose, | |||
| onCloseOverflowButton, | |||
| }: AppMenuContextMenuProps) => { | |||
| const panels = useMemo( | |||
| const [activePanelId, setActivePanelId] = useState<string>('0'); | |||
Contributor
There was a problem hiding this comment.
is '0' a valid logical value here?
Member
Author
There was a problem hiding this comment.
Panel ids can have both string and number values. Since we're not allowing for setting them by users, we can keep them as one type and using strings seems easiest here to avoid type casting.
ee14e6f to
9fd31a8
Compare
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes sub items with popovers not having their test id passed down to the panel.
Closes: https://github.com/elastic/kibana-team/issues/2650