[ResponseOps] Update task runner to use core services by darnautov · Pull Request #248866 · elastic/kibana

darnautov · 2026-01-13T16:22:58Z

Summary

Updates the rule executor task to use DI container and internal services

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…vices

cnasikas

Great work! It is really nice to see how powerful the DI system is. I left some comments, mostly nits.

x-pack/platform/plugins/shared/alerting_v2/server/lib/rule_executor/build_alert_events.ts

x-pack/platform/plugins/shared/alerting_v2/server/lib/rule_executor/build_alert_events.test.ts

x-pack/platform/plugins/shared/alerting_v2/server/lib/rule_executor/task_definition.ts

cnasikas · 2026-01-16T13:08:02Z

x-pack/platform/plugins/shared/alerting_v2/server/lib/rule_executor/task_runner.ts

+      });
+    } catch (error) {
+      if (abortController.signal.aborted) {
+        throw new Error('Search has been aborted due to cancelled execution');


Maybe it is better to return instead of throwing an error.

Not sure if we want to exit silently if the task manager aborts 🤔

What are we trying to achieve by throwing an error here?

cnasikas · 2026-01-16T13:08:49Z

x-pack/platform/plugins/shared/alerting_v2/server/lib/rule_executor/task_runner.ts

+    const scheduledAt = taskInstance.scheduledAt;
+    const scheduledTimestamp =
+      (typeof scheduledAt === 'string' ? scheduledAt : undefined) ??
+      (taskInstance.startedAt instanceof Date ? taskInstance.startedAt.toISOString() : undefined) ??


nit: Could we extract this to a function to make it more readable? Also, the taskInstance.scheduledAt is typed as Date. Is it wrong?

cnasikas · 2026-01-16T13:10:45Z

x-pack/platform/plugins/shared/alerting_v2/server/lib/services/logger_service/logger_service.ts

+  error(params: ErrorParams): void;
+}
+
+export const LoggerServiceToken = Symbol.for(


nit: Maybe we can follow the same pattern as with the other tokens and have a tokens.ts file or the opposite, but to be consistent.

cnasikas · 2026-01-16T13:12:02Z

.../platform/plugins/shared/alerting_v2/server/lib/services/query_service/query_service.mock.ts

+export function createMockQueryService() {
+  type QueryServiceMock = jest.Mocked<QueryServiceContract>;
+  const queryService = {
+    executeQuery: jest.fn() as jest.MockedFunction<QueryServiceContract['executeQuery']>,


nit: Why do we need to cast here?

so it has the same type signature, e.g. correct argument types etc.

I would expect jest.Mocked<QueryServiceContract>; + satisfies to be enough, no.

cnasikas · 2026-01-16T13:12:44Z

...lerting_v2/server/lib/services/rules_saved_object_service/rules_saved_object_service.mock.ts

+export function createMockRulesSavedObjectService() {
+  type RulesSavedObjectServiceMock = jest.Mocked<RulesSavedObjectServiceContract>;
+  const rulesSavedObjectService = {
+    create: jest.fn() as jest.MockedFunction<RulesSavedObjectServiceContract['create']>,


nit: Why do we need to cast here?

so it has the same type signature, e.g. correct argument types etc.

I would expect jest.Mocked<QueryServiceContract>; + satisfies to be enough, no.

when you use jest.fn() it has no clue about method arguments. You get a TS error like [tsc] 1456 mockResolvedValue(value: ResolvedValue<T>): this; proc [tsc] ~~~~~~~~~~~~~~~~~~~~~~~ proc [tsc] An argument for 'value' was not provided.

…vices

…tion_tests/ci_checks

elasticmachine · 2026-01-16T17:55:56Z

💔 Build Failed

Buildkite Build
Commit: c47567a

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #52 / Cloud Security Posture Tests get rules states API get rules states successfully
[job] [logs] FTR Configs #124 / console app console autocomplete feature Autocomplete shouldnt trigger within a multiline block comment
[job] [logs] Serverless Entity Analytics - Security Cypress Tests #1 / Entity Analytics Dashboard With anomalies data should enable a job and renders the table with pagination should enable a job and renders the table with pagination
[job] [logs] Scout Test Run Builder / selectable with search field
[job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiSelectable - selectable with search field

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [56b1532]

History

darnautov added 3 commits January 13, 2026 12:51

refactor task definition to use DI

c79ffde

Merge remote-tracking branch 'upstream/alerting_v2' into refactor-ser…

040cab9

…vices

use query and storage services

1d4d941

darnautov requested a review from cnasikas January 13, 2026 16:23

security as required plugin

fb1168e

darnautov mentioned this pull request Jan 14, 2026

[ResponseOps] Alerting v2: Initialize all resources #248696

Merged

1 task

kibanamachine and others added 6 commits January 14, 2026 11:19

Changes from node scripts/lint_ts_projects --fix

c796ac2

Changes from node scripts/eslint_all_files --no-cache --fix

eb4b945

fix TS error

c8d488c

Merge remote-tracking branch 'upstream/alerting_v2' into refactor-ser…

92545f5

…vices

fix lint error

461d376

Refactor RulesClient to use RulesSavedObjectService

ef772b6

darnautov marked this pull request as ready for review January 15, 2026 15:22

darnautov requested a review from a team as a code owner January 15, 2026 15:22

kibanamachine and others added 5 commits January 15, 2026 15:34

Changes from node scripts/lint_ts_projects --fix

7c80d27

refactor to task runner factory and class

97d9b4e

fix eslint

30e9b80

add mocks and tests

a1b71fc

simplify task runner factory

dc888a3

cnasikas approved these changes Jan 16, 2026

View reviewed changes

kibanamachine and others added 10 commits January 16, 2026 13:15

Changes from node scripts/eslint_all_files --no-cache --fix

2350369

use rules client mock

59ccae4

remove type casting

7d3068a

remove check for plugin enabled in the task runner

f06ebe8

replace redundant getRuleAttributes method

d5fe2c2

return doc id with get

0ed5db6

use same taskType for factory

7a4c8b3

update grouping key test

9a1f49a

update buildAlertEventsFromEsqlResponse args

c0a9f3e

Merge remote-tracking branch 'upstream/alerting_v2' into refactor-ser…

5e91227

…vices

Changes from node scripts/jest_integration -u src/core/server/integra…

c47567a

…tion_tests/ci_checks

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner January 16, 2026 17:25

darnautov merged commit fb0a147 into elastic:alerting_v2 Jan 16, 2026
11 of 13 checks passed

kdelemme mentioned this pull request Jan 20, 2026

alertingv2/streaming esql #249735

Closed

This was referenced Feb 11, 2026

Alerting_v2: Dispatcher notification policy #252758

Merged

feat(rna): add getRules client method #253355

Merged

kdelemme mentioned this pull request Mar 23, 2026

feat(alertingv2): update list notification policies table #259114

Merged

Conversation

darnautov commented Jan 13, 2026

Summary

Checklist

Uh oh!

cnasikas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnasikas Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cnasikas Jan 16, 2026 •

edited

Loading

elasticmachine commented Jan 16, 2026 •

edited

Loading