[Rollups] Fix time field not being recognized due to ordering of aggs#24615
Merged
jen-huang merged 3 commits intoelastic:feature/rollup-supportfrom Oct 26, 2018
Merged
Conversation
bd1e016 to
56b9a39
Compare
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
Retest |
Contributor
💚 Build Succeeded |
cjcenizal
approved these changes
Oct 26, 2018
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Tested in browser, the reported problem is fixed. Code LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #24523
Previously, for certain rollup job configurations, the time field (aka
date_histogramagg field) would not be recognized when creating a corresponding rollup index pattern due to the ordering of the job's aggs.This fix allows the time field to override any other agg that may be defined on it (
maxandmin).PR also cleans up some extraneous UI whitespace introduced by the conversion to EUI panels.