[WorkplaceAI] Add Notion as ConnectorV2#245097
Merged
lorenabalan merged 28 commits intomainfrom Dec 9, 2025
Merged
Conversation
2 tasks
…to lb/datasourcesregistry
seanstory
reviewed
Dec 5, 2025
Member
seanstory
left a comment
There was a problem hiding this comment.
Awesome. Ok as a follow-up, but I think we'll probably want tests and docs (see the PR checklist). I've added some potential examples in https://github.com/elastic/kibana/pull/245421/files
src/platform/packages/shared/kbn-connector-specs/src/specs/notion.ts
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-connector-specs/src/specs/notion.ts
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-connector-specs/src/specs/notion.ts
Outdated
Show resolved
Hide resolved
src/platform/packages/shared/kbn-connector-specs/src/specs/notion.ts
Outdated
Show resolved
Hide resolved
seanstory
approved these changes
Dec 9, 2025
Contributor
Author
Thanks! Added https://github.com/elastic/search-team/issues/12103 so we don't forget. |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
|
ymao1
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes [WorkplaceAI] Define one Kibana stack connector from spec #12056
We want to add Notion as a "data connector", i.e. a source of data a user may want to connect and chat with. For this, we need a stack connector for the interaction with the 3rd party.
This PR is converting the original Notion ksc from POC into ksc "v2".
Related PRs ➡️ #245132 also enables us to send headers with every request, which is what we need for Notion (to specify the version).
Note for future self:
schemais for setting up custom connector-specific configuration. At this time I haven't identified a need for this for the Notion connector.example of how to enable it in the future:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.