Skip to content

[WorkplaceAI] Add Notion as ConnectorV2#245097

Merged
lorenabalan merged 28 commits intomainfrom
lb/notion-connectors-v2
Dec 9, 2025
Merged

[WorkplaceAI] Add Notion as ConnectorV2#245097
lorenabalan merged 28 commits intomainfrom
lb/notion-connectors-v2

Conversation

@lorenabalan
Copy link
Copy Markdown
Contributor

@lorenabalan lorenabalan commented Dec 3, 2025

Summary

Closes [WorkplaceAI] Define one Kibana stack connector from spec #12056

We want to add Notion as a "data connector", i.e. a source of data a user may want to connect and chat with. For this, we need a stack connector for the interaction with the 3rd party.

This PR is converting the original Notion ksc from POC into ksc "v2".

Screenshot 2025-12-03 at 15 43 52 Screenshot 2025-12-05 at 16 24 55

Related PRs ➡️ #245132 also enables us to send headers with every request, which is what we need for Notion (to specify the version).

Note for future self:

schema is for setting up custom connector-specific configuration. At this time I haven't identified a need for this for the Notion connector.
example of how to enable it in the future:

  schema: z.object({
    my_field: z.string(),
    method: z
      .enum(['GET', 'POST', 'PUT', 'PATCH', 'DELETE'])
      .meta({ label: 'Method' })
      .default('POST'),
    url: z.url().meta({ label: 'URL', placeholder: 'https://...' }),
  }),
Screenshot 2025-12-05 at 17 21 52

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Base automatically changed from lb/datasourcesregistry to main December 4, 2025 19:00
@lorenabalan lorenabalan changed the title Notion as ConnectorV2 [Workplace AI] Add Notion as ConnectorV2 Dec 5, 2025
@lorenabalan lorenabalan marked this pull request as ready for review December 5, 2025 16:45
@lorenabalan lorenabalan requested a review from a team as a code owner December 5, 2025 16:45
@lorenabalan lorenabalan added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Dec 5, 2025
@lorenabalan lorenabalan changed the title [Workplace AI] Add Notion as ConnectorV2 [WorkplaceAI] Add Notion as ConnectorV2 Dec 5, 2025
Copy link
Copy Markdown
Member

@seanstory seanstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Ok as a follow-up, but I think we'll probably want tests and docs (see the PR checklist). I've added some potential examples in https://github.com/elastic/kibana/pull/245421/files

@lorenabalan lorenabalan requested a review from seanstory December 9, 2025 13:44
Copy link
Copy Markdown
Member

@seanstory seanstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming docs and tests come in a follow-up, LGTM!

@lorenabalan
Copy link
Copy Markdown
Contributor Author

[WorkplaceAI] Define one Kibana stack connector from spec #12056

Thanks! Added https://github.com/elastic/search-team/issues/12103 so we don't forget.

@lorenabalan lorenabalan enabled auto-merge (squash) December 9, 2025 14:17
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
stackConnectors 503 506 +3
workflowsManagement 1974 1975 +1
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 827.3KB 829.7KB +2.4KB
workflowsManagement 4.3MB 4.3MB +1.9KB
total +4.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackConnectors 72.8KB 72.8KB +62.0B
Unknown metric groups

async chunk count

id before after diff
stackConnectors 111 112 +1

ESLint disabled line counts

id before after diff
@kbn/connector-specs 0 1 +1

miscellaneous assets size

id before after diff
stackConnectors 49.4KB 68.4KB +19.0KB

Total ESLint disabled count

id before after diff
@kbn/connector-specs 0 1 +1

History

@lorenabalan lorenabalan merged commit 61eae8c into main Dec 9, 2025
12 checks passed
@lorenabalan lorenabalan deleted the lb/notion-connectors-v2 branch December 9, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants