[9.2]@kbn/cleanup-before-exit: don't pass in undefined exit code (#243499)#243579
Merged
jbudz merged 1 commit intoelastic:9.2from Nov 20, 2025
Merged
[9.2]@kbn/cleanup-before-exit: don't pass in undefined exit code (#243499)#243579jbudz merged 1 commit intoelastic:9.2from
jbudz merged 1 commit intoelastic:9.2from
Conversation
…243499) `@kbn/cleanup-before-exit` previously called `process.exit(exitCode)` even when the exitCode is undefined. Passing in `undefined` actually overrides a previously set `process.exitCode`. This unintentionally causes the exitCode to be 0 when process.exitCode has been set to a non-zero value. After elastic#228692 was merged, `@kbn/cleanup-before-exit` became active for FTR runs because `initMetrics` uses this function, and FTR uses `process.exitCode`, which caused false positives in CI. We're skipping test suites to allow the fix to roll in, and prevent further unnoticed errors going to main. Skipped suites / cases in: - [ ] .buildkite/ftr_platform_stateful_configs.yml / x-pack/performance/journeys_e2e/aiops_log_rate_analysis.ts - [ ] src/platform/test/api_integration/apis/dashboards/get_dashboard/main.ts - [x] src/platform/test/functional/apps/discover/group10/_lens_vis.ts - [ ] x-pack/platform/test/fleet_api_integration/apis/package_policy/delete.ts - [ ] x-pack/platform/test/functional_execution_context/tests/log_correlation.ts - [ ] x-pack/solutions/search/test/functional_search/tests/classic_navigation.basic.ts - [ ] x-pack/solutions/search/test/functional_search/tests/classic_navigation.ts - [ ] x-pack/solutions/security/test/api_integration/apis/cloud_security_posture/benchmark/v2.ts - [ ] x-pack/solutions/security/test/serverless/api_integration/test_suites/platform_security/authorization.ts - [ ] x-pack/platform/test/functional/apps/aiops/change_point_detection.ts - [ ] src/platform/test/api_integration/apis/metrics_experience/fields.ts - [ ] x-pack/solutions/security/test/security_solution_api_integration/test_suites/genai/attack_discovery/schedules/trial_license_complete_tier/find/find.ts - [ ] x-pack/platform/test/reporting_functional/reporting_and_security/management.ts --------- Co-authored-by: Alex Szabo <alex.szabo@elastic.co> Co-authored-by: Jonathan Budzenski <jon@elastic.co> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
nickofthyme
approved these changes
Nov 20, 2025
Contributor
💚 Build Succeeded
Metrics [docs]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#243499