[Controls Anywhere] Fix Discover to Dashboard embeddable transfer service#242214
Merged
Heenawter merged 8 commits intoelastic:controlsAnywherefrom Nov 12, 2025
Conversation
Heenawter
commented
Nov 7, 2025
Comment on lines
+238
to
+239
| trackPanel.setScrollToPanelId(first.embeddableId); | ||
| trackPanel.setHighlightPanelId(first.embeddableId); |
Contributor
Author
There was a problem hiding this comment.
We used to highlight the last panel in the array because this was in the loop; however, if we are making the assumption that the first embeddable is the important one (and we are placing all other panels around it), I think it makes more sense to highlight that one instead.
Heenawter
commented
Nov 7, 2025
Comment on lines
+215
to
+219
| /** | ||
| * We can assume that all panels being sent as a single package are related; so, | ||
| * place them close together by grouping them around the first embeddable. | ||
| */ | ||
| beside: uuid === first.embeddableId ? undefined : first.embeddableId, |
Contributor
Author
There was a problem hiding this comment.
Previously, if you had a controls-sized gap in your Dashboard, the controls would try to fill those gaps - which means they would be separated from the main histogram chart. By using the beside like this, we prevent that.
…trolsAnywhere-fix-embeddable-transfer_2025-11-06
… github.com:heenawter/kibana into controlsAnywhere-fix-embeddable-transfer_2025-11-06
…tion_tests/ci_checks
Contributor
💔 Build Failed
Failed CI StepsHistory
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This work is being merged into a feature branch, not main!
Because of this, we only need a review from @elastic/kibana-presentation for now.
Closes #241678
Summary
This PR ensures that saving the histogram from Discover to a Dashboard carries the controls with it.
Screen.Recording.2025-11-07.at.1.51.26.PM.mov