[Controls Anywhere] Fix errors with changing control types#241019
Merged
Zacqary merged 4 commits intoelastic:controlsAnywherefrom Oct 30, 2025
Merged
[Controls Anywhere] Fix errors with changing control types#241019Zacqary merged 4 commits intoelastic:controlsAnywherefrom
Zacqary merged 4 commits intoelastic:controlsAnywherefrom
Conversation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Zacqary
commented
Oct 28, 2025
...d/controls/public/actions/edit_control_display_settings/control_display_settings_popover.tsx
Show resolved
Hide resolved
This reverts commit 07dbb16.
Heenawter
reviewed
Oct 28, 2025
src/platform/plugins/shared/dashboard/public/dashboard_api/layout_manager/layout_manager.ts
Outdated
Show resolved
Hide resolved
Zacqary
commented
Oct 29, 2025
| public readonly MenuItem = ({ context }: { context: EmbeddableApiContext }) => { | ||
| const { embeddable } = context; | ||
| if (!apiIsPinnableControlApi(embeddable)) throw new IncompatibleActionError(); | ||
| if (!apiIsPinnableControlApi(embeddable)) return null; |
Contributor
Author
There was a problem hiding this comment.
Ran into a runtime error here when resetting the dashboard. This fixes it, figured it didn't need a second PR
Contributor
💔 Build Failed
Failed CI StepsHistory
|
Heenawter
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #240190
Panel not founderror when changing a pinned control from one type to another, e.g. Options List to Range SliderFixes a runtime error related to the display settings popover when deleting multiple controls