Skip to content

[EUI] Test local EUI with repositionOnScroll defaults#240882

Closed
weronikaolejniczak wants to merge 1 commit intoelastic:mainfrom
weronikaolejniczak:test/reposition-on-scroll-defaults
Closed

[EUI] Test local EUI with repositionOnScroll defaults#240882
weronikaolejniczak wants to merge 1 commit intoelastic:mainfrom
weronikaolejniczak:test/reposition-on-scroll-defaults

Conversation

@weronikaolejniczak
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak commented Oct 27, 2025 •
edited
Loading

Summary

Test changes from elastic/eui#9152.

QA

  1. Test in the current layout. Run yarn start.
  2. Test in grid layout:
    2.1. Set kibana.dev.yml to: 
    feature_flags.overrides:
  core.chrome.layoutType: 'grid'
    2.2. Set componentDefaults in src/platform/packages/shared/react/kibana_context/root/eui_provider.tsx:82 to: 
    const componentDefaults: EuiProviderProps<unknown>['componentDefaults'] = {
  EuiFlyout: {
    includeSelectorInFocusTrap: `[data-eui-includes-in-flyout-focus-trap="true"]`,
  },
  EuiPopover: {
    repositionOnScroll: true,
  },
  EuiToolTip: {
    repositionOnScroll: true,
  },
};
    2.3. Run yarn kbn bootstrap. Any changes to the EUI provider need reinstalling deps.
    2.4. Run yarn start.

Before

Kapture.2025-10-31.at.21.16.38.mp4

After

Kapture.2025-10-31.at.21.20.25.mp4

@weronikaolejniczak weronikaolejniczak force-pushed the test/reposition-on-scroll-defaults branch from 72440f2 to 9ddde77 Compare October 27, 2025 18:11
@weronikaolejniczak weronikaolejniczak self-assigned this Oct 27, 2025
@weronikaolejniczak weronikaolejniczak added EUI ci:cloud-deploy Create or update a Cloud deployment labels Oct 27, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 27, 2025 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@weronikaolejniczak weronikaolejniczak added the ci:cloud-persist-deployment Persist cloud deployment indefinitely label Oct 27, 2025
@weronikaolejniczak weronikaolejniczak mentioned this pull request Oct 27, 2025
Merged
16 tasks
@weronikaolejniczak weronikaolejniczak force-pushed the test/reposition-on-scroll-defaults branch 6 times, most recently from 2b26e11 to fe404c7 Compare October 29, 2025 11:18
@weronikaolejniczak weronikaolejniczak added the ci:project-deploy-security Create a Security Serverless Project label Oct 31, 2025
@weronikaolejniczak weronikaolejniczak force-pushed the test/reposition-on-scroll-defaults branch from fe404c7 to bebbf2c Compare October 31, 2025 20:09
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 31, 2025

PR Cloud deployment started at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/527

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 31, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #33 / Alerting builtin alertTypes es_query rule runs correctly: threshold on ungrouped hit count < > for searchSource search type
  • [job] [logs] FTR Configs #51 / Serverless Observability - Deployment-agnostic APM API integration tests APM alerts transaction duration alert create rule for opbeans-node using kql filter shows alert count=1 for opbeans-node on service inventory
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiCheckBox - checkbox
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiCheckBox - checkbox
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiCheckBox - checkbox
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiComboBox - with multiple selections (pills)
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiComboBox - with multiple selections (pills)
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiComboBox - with multiple selections (pills)
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiComboBox - with the single selection
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiComboBox - with the single selection
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiComboBox - with the single selection
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiDataGrid - data grid, run
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiDataGrid - data grid, run
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiDataGrid - data grid, run
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiSelectable - selectable with search field
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiSelectable - selectable with search field
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiSelectable - selectable with search field
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiToast - toast
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiToast - toast
  • [job] [logs] Scout Test Run Builder / serverless-security - EUI testing wrapper: EuiToast - toast

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.4MB 6.4MB +807.0B

History

cc @weronikaolejniczak

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 31, 2025

Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/716

@weronikaolejniczak
Copy link
Copy Markdown
Contributor Author

weronikaolejniczak commented Nov 5, 2025

@Dosant The PR has been merged on EUI-side, it will be a part of the next week EUI release. I'll let you handle the integration for Kibana, lmk if you need any help! 🙏🏻

@weronikaolejniczak weronikaolejniczak deleted the test/reposition-on-scroll-defaults branch February 10, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@weronikaolejniczak weronikaolejniczak

Labels

ci:cloud-deploy Create or update a Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely ci:project-deploy-security Create a Security Serverless Project EUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weronikaolejniczak @elasticmachine @kibanamachine @JasonStoltz