[Controls Anywhere] Add controls sub-menu#240543
Merged
cqliu1 merged 16 commits intoelastic:controlsAnywherefrom Oct 29, 2025
Merged
[Controls Anywhere] Add controls sub-menu#240543cqliu1 merged 16 commits intoelastic:controlsAnywherefrom
cqliu1 merged 16 commits intoelastic:controlsAnywherefrom
Conversation
cqliu1
commented
Oct 24, 2025
src/platform/plugins/shared/dashboard/public/dashboard_app/top_nav/add_menu/show_add_menu.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Heenawter
reviewed
Oct 27, 2025
...orm/plugins/shared/dashboard/public/dashboard_actions/execute_create_control_panel_action.ts
Outdated
Show resolved
Hide resolved
Heenawter
reviewed
Oct 27, 2025
src/platform/plugins/shared/controls/public/actions/create_control_action.tsx
Outdated
Show resolved
Hide resolved
Heenawter
reviewed
Oct 27, 2025
src/platform/plugins/shared/controls/public/actions/create_esql_control_action.tsx
Outdated
Show resolved
Hide resolved
Heenawter
approved these changes
Oct 28, 2025
Contributor
Heenawter
left a comment
There was a problem hiding this comment.
Left a small nit but otherwise LGTM! Thanks so much for tackling this for us 🎉
src/platform/plugins/shared/dashboard/public/dashboard_app/top_nav/add_menu/show_add_menu.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
…into controls-anywhere/controls-sub-menu
…com/cqliu1/kibana into controls-anywhere/controls-sub-menu
Contributor
💔 Build Failed
Failed CI StepsHistory
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #237521.
This adds back the controls sub-menu in the top nav
Addmenu.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.