[Controls Anywhere] Make "Use global filters" setting ignore control selections#240375
Merged
Zacqary merged 4 commits intoelastic:controlsAnywherefrom Oct 28, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Zacqary
commented
Oct 23, 2025
|
|
||
| ignoreValidations, | ||
| ...fetchContext, | ||
| filters: getFetchContextFilters(fetchContext, useGlobalFilters), |
Contributor
Author
There was a problem hiding this comment.
This fixes a bug where:
- The user disables Use Global Filters, and then the control fetches new data with filters disabled
- The user re-enables Use Global Filters, but the control doesn't fetch new data until the user makes a change to the filters elsewhere on the dashboard
When we mutated fetchContext.filters, it wouldn't replace the missing filters when only the useGlobalFilters subject emitted a new value.
This was probably a preexisting bug.
Heenawter
approved these changes
Oct 27, 2025
Heenawter
requested changes
Oct 27, 2025
Contributor
Heenawter
left a comment
There was a problem hiding this comment.
Actually - sorry 🤦 If the legacy chainingSystem was NONE, we wanted to do a transform on the control group input so that useGlobalFilters was false
Do you mind doing that? See src/platform/plugins/shared/dashboard/server/content_management/v1/transforms/out/transform_control_group_out.ts
Zacqary
commented
Oct 27, 2025
.../shared/dashboard/server/content_management/v1/transforms/out/transform_control_group_out.ts
Show resolved
Hide resolved
Contributor
💔 Build Failed
Failed CI StepsHistory
|
Heenawter
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #237887
When setting "Use global filters" on a control, it will now pass a set of empty filters to the
fetchContextwhen fetching new data, instead of keeping filters from all the other controls on the dashboard.