Skip to content

chore(NA): upgrade typescript into v5.9.3#239670

Merged
mistic merged 65 commits intoelastic:mainfrom
mistic:upgrade-typescript-5.9.3
Nov 28, 2025
Merged

chore(NA): upgrade typescript into v5.9.3#239670
mistic merged 65 commits intoelastic:mainfrom
mistic:upgrade-typescript-5.9.3

Conversation

@mistic
Copy link
Copy Markdown
Contributor

@mistic mistic commented Oct 20, 2025 •
edited by kibanamachine
Loading

Closes https://github.com/elastic/kibana-operations/issues/306

This PR bumps the Typescript version used on Kibana into v5.9.3. The full set of changes can be found here.

In order to make assumptions over the codebase and all the type of errors I choose to mark the failures with @ts-expect-error and let each team decide how to handle it.

There is a list below with the files (and teams those belong to) where the annotations were added. If each team could provide help of fixing the ones under their domain it would be fantastic. It can be done in this PR or in subsequent ones.

Here it goes the list for follow up:

@elastic/kibana-core

@elastic/response-ops

@elastic/kibana-visualizations PR that will address these changes #241765

@elastic/kibana-data-discovery

@elastic/kibana-management

@elastic/kibana-presentation

@elastic/appex-sharedux

@elastic/obs-ai-assistant

@elastic/ml-ui

@elastic/kibana-cases

@elastic/obs-ux-logs-team

@elastic/fleet

@elastic/kibana-reporting-services

@elastic/kibana-security

@elastic/streams-program-team

@elastic/obs-ux-infra_services-team

@elastic/obs-ux-management-team

@elastic/security-detection-engine

@elastic/security-solution

@mistic mistic added chore Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.2.0 v9.0.6 v9.3.0 v9.1.6 v8.19.6 labels Oct 20, 2025
sabarasaba
sabarasaba approved these changes Oct 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patched @elastic/kibana-management file with 8345e4c

@mistic
Copy link
Copy Markdown
Contributor Author

mistic commented Oct 23, 2025

@sabarasaba even before I've opened the PR 😄 Thank you for the fixes 😊

@mistic mistic force-pushed the upgrade-typescript-5.9.3 branch from 5485993 to b0b2358 Compare October 30, 2025 00:40
davismcphee
davismcphee approved these changes Nov 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some fixes for the Data Discovery types in 337659e, LGTM 👍

@janmonschke
Copy link
Copy Markdown
Contributor

janmonschke commented Nov 27, 2025

@mistic I fixed the kibana-cases type issues in e50008a

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 28, 2025 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 4148aaa
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-239670-4148aaa3f6b7

Metrics [docs]

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/connector-specs 0 5 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 1.4MB 1.4MB +22.0B
cloudSecurityPosture 643.0KB 643.0KB -4.0B
datasetQuality 427.9KB 428.0KB +78.0B
securitySolution 11.1MB 11.1MB -54.0B
slo 987.9KB 987.8KB -116.0B
synthetics 1.0MB 1.0MB -11.0B
total -85.0B

History

@mistic
Copy link
Copy Markdown
Contributor Author

mistic commented Nov 28, 2025

We have a good amount of approvals and fixes in, the others could be done in further PRs. I'm going ahead and merge this in.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 28, 2025

Starting backport for target branches: 8.19, 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/19773809157

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 28, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
❌ 9.1 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.1:
- Upgrade body-parser from 2.2.0 to 2.2.1 (#244352)
- Upgrade glob 10.4.5 → 10.5.0 (#243797)
- Update dependency semver to ^7.7.3 (main) (#239989)
- Update OpenAPI Spec (main) (#230113)
- [CI] Auto regenerate moon projects (#237609)
- Update dependency @xyflow/react to ^12.9.2 (main) (#243136)
❌ 9.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 239670

Questions ?

Please refer to the Backport tool documentation

@sorenlouv
Copy link
Copy Markdown
Contributor

sorenlouv commented Nov 28, 2025 •
edited
Loading

@mistic Huge achievement getting us from a 2-year-old version of Typescript to the latest! I don't think we've ever been on the cutting edge before. Amazing job!

Ps. So hyped about finally having inferred type predicates (aka .filter(x => x !== null) now correctly narrows the type!!)

This was referenced Nov 28, 2025
Merged
Merged
@kibanamachine kibanamachine mentioned this pull request Dec 1, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 1, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @mistic

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 2, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @mistic

@kibanamachine kibanamachine mentioned this pull request Dec 3, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 3, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @mistic

@mistic mistic mentioned this pull request Dec 4, 2025
Merged
@kibanamachine kibanamachine mentioned this pull request Dec 4, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 4, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @mistic

@mistic
Copy link
Copy Markdown
Contributor Author

mistic commented Dec 5, 2025

@sorenlouv thank you! We wanted to get ready to try the new native TS compiler once it gets released 😎

This was referenced Feb 25, 2026
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janmonschke janmonschke janmonschke approved these changes

@maxcold maxcold maxcold approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@markov00 markov00 markov00 approved these changes

@adcoelho adcoelho adcoelho approved these changes

@kapral18 kapral18 kapral18 approved these changes

@maximpn maximpn maximpn approved these changes

@delanni delanni delanni approved these changes

@nkhristinin nkhristinin nkhristinin approved these changes

@joeypoon joeypoon joeypoon approved these changes

@mohamedhamed-ahmed mohamedhamed-ahmed mohamedhamed-ahmed approved these changes

@stratoula stratoula stratoula approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@justinkambic justinkambic justinkambic approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@rmyz rmyz rmyz approved these changes

@davismcphee davismcphee davismcphee approved these changes

@fake-haris fake-haris fake-haris approved these changes

@elena-shostak elena-shostak elena-shostak approved these changes

@machadoum machadoum Awaiting requested review from machadoum machadoum is a code owner automatically assigned from elastic/security-entity-analytics

@parkiino parkiino Awaiting requested review from parkiino parkiino is a code owner automatically assigned from elastic/security-defend-workflows

+1 more reviewer

@sorenlouv sorenlouv sorenlouv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:version Backport to applied version labels chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.19.8 v9.1.8 v9.2.2 v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.