[Controls Anywhere] Pin and unpin controls#238142
Merged
Heenawter merged 7 commits intoelastic:controlsAnywherefrom Oct 14, 2025
Merged
[Controls Anywhere] Pin and unpin controls#238142Heenawter merged 7 commits intoelastic:controlsAnywherefrom
Heenawter merged 7 commits intoelastic:controlsAnywherefrom
Conversation
38eba99 to
05125bd
Compare
05125bd to
6892729
Compare
Heenawter
commented
Oct 14, 2025
| }); | ||
|
|
||
| for (let y = targetPanel?.gridData.y ?? 0; y < maxY; y++) { | ||
| for (let y = targetPanel?.grid.y ?? 0; y < maxY; y++) { |
Contributor
Author
There was a problem hiding this comment.
This is a type fix since we switch gridData to grid on main
… src/core/server/integration_tests/ci_checks'
Contributor
💔 Build Failed
Failed CI StepsHistory
cc @Heenawter |
ThomThomson
approved these changes
Oct 14, 2025
Contributor
ThomThomson
left a comment
There was a problem hiding this comment.
Code is looking great! Nice simple action definition, interfaces and type guards. Great unit tests
| delete newControls[uuid]; | ||
| // adjust the order of the remaining controls | ||
| for (const controlId of Object.keys(newControls)) { | ||
| if (newControls[controlId].order > originalOrder) newControls[controlId].order--; |
Contributor
There was a problem hiding this comment.
Nice, great to retain order here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This work is being merged into a feature branch, not main!
Because of this, we only need a review from @elastic/kibana-presentation for now.
Type failures are expected because the feature branch is currently in an incomplete state, where the controls that have not yet been converted (time slider, etc.) are dependent on things that no longer exist.
Closes #221574
Summary
This PR adds an action to pin and unpin control panels.
Screen.Recording.2025-10-14.at.12.58.38.PM.mov
Important
Notice that
widthandgroware lost on the unpin action - this is expected. These values can be configured again once #234681 is complete.Checklist