[8.19] [Synthetics] Support projects multi spaces !! (#227674)#228726
Merged
shahzad31 merged 8 commits intoelastic:8.19from Jul 22, 2025
Merged
[8.19] [Synthetics] Support projects multi spaces !! (#227674)#228726shahzad31 merged 8 commits intoelastic:8.19from
shahzad31 merged 8 commits intoelastic:8.19from
Conversation
## Summary Follow up to elastic#221568 This PR allows specifying spaces param in project monitors. Following use-cases have been supported User will be able to supports `spaces: ["defautl", "test"] ` Proper API tests have been added to provide additional coverage for the use-case. ### Validations - [ ] The route to which project api is being called should always be part of spaces if defined. - [ ] Non existent space will throw error - [ ] User must have permission to all specified spaces for CRUDS - [ ] User can also specify * to create monitors in all spaces ### PR Testing You can use following project monitors PR to test this PR elastic/synthetics#1052 First create few project monitors before this branch and then switch and specify multi spaces as part of the options and verify in UI that editing , adding and deletion works as expected on push command. (cherry picked from commit 39d87d0) # Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/synthetics/create_monitor_project_multi_space.ts
4 tasks
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
There are no new commits on the base branch. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports support for multi-space project monitors in Synthetics from version 8.19. The feature allows specifying spaces in project monitor configurations, enabling monitors to be created across multiple Kibana spaces.
- Adds multi-space validation and permission checks for project monitors
- Implements space-aware monitor creation and updates with proper namespace handling
- Adds comprehensive test coverage for multi-space functionality
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| create_monitor_project_multi_space.ts | New comprehensive test suite for multi-space project monitor functionality |
| index.ts | Adds test file reference for multi-space monitor tests |
| create_monitor_project.ts | Minor formatting changes to import statements and test description |
| add_monitor_project_multi_space.ts | Adds extensive multi-space permission and security test cases |
| common_fields.ts | Adds spaces field to monitor configuration normalization |
| common_fields.test.ts | Updates test expectations to include spaces field |
| synthetics_route_wrapper.ts | Adds Kibana response handling for better error management |
| monitor_config_repository.ts | Major refactoring to support space-aware monitor creation and updates |
| monitor_config_repository.test.ts | Comprehensive test updates for new repository functionality |
| synthetics_monitor.ts | File deletion (copyright header only) |
| add_monitor_project.ts | Adds multi-space validation and permission checking logic |
| edit_monitor_bulk.ts | Updates to use new monitor update signature |
| monitor_types_project.ts | Adds spaces field to project monitor type definition |
x-pack/test/api_integration/deployment_agnostic/apis/observability/synthetics/index.ts
Outdated
Show resolved
Hide resolved
...tion/deployment_agnostic/apis/observability/synthetics/create_monitor_project_multi_space.ts
Show resolved
Hide resolved
...tion/deployment_agnostic/apis/observability/synthetics/create_monitor_project_multi_space.ts
Show resolved
Hide resolved
x-pack/solutions/observability/plugins/synthetics/server/services/monitor_config_repository.ts
Show resolved
Hide resolved
x-pack/solutions/observability/plugins/synthetics/server/services/monitor_config_repository.ts
Show resolved
Hide resolved
…lity/synthetics/index.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/dashboards --include-path /api/maintenance_window --update --no-serverless'
cesco-f
approved these changes
Jul 21, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation