[6.4] Add explicit format parameter to docvalue_fields requests (#22771)#22838
Merged
Bargs merged 1 commit intoelastic:6.4from Sep 7, 2018
Merged
[6.4] Add explicit format parameter to docvalue_fields requests (#22771)#22838Bargs merged 1 commit intoelastic:6.4from
Bargs merged 1 commit intoelastic:6.4from
Conversation
…2771) Fixes elastic#22484 Elasticsearch 6.4 added an optional `format` parameter for doc_value fields. In 6.x if the param is not included it defaults to returning the same values we see in scripted fields. In 7.0 this is changing to use the mapping configured format by default. In kibana we want our date values in ISO format, so this PR future proofs us for 7.0. It also eliminates deprecation warnings ES is returning due to the missing param, which is currently spamming some users.
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22484
Elasticsearch 6.4 added an optional
formatparameter for doc_valuefields. In 6.x if the param is not included it defaults to returning
the same values we see in scripted fields. In 7.0 this is changing to
use the mapping configured format by default. In kibana we want our date
values in ISO format, so this PR future proofs us for 7.0. It also eliminates
deprecation warnings ES is returning due to the missing param, which is
currently spamming some users.