Skip to content

[8.17] [Search sessions] Add singulars/plurals to expiration badges (#227035)#227258

Merged
AlexGPlay merged 1 commit intoelastic:8.17from
AlexGPlay:backport/8.17/pr-227035
Jul 15, 2025
Merged

[8.17] [Search sessions] Add singulars/plurals to expiration badges (#227035)#227258
AlexGPlay merged 1 commit intoelastic:8.17from
AlexGPlay:backport/8.17/pr-227035

Conversation

@AlexGPlay
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

…#227035)

## Summary

Closes elastic#122931

Adds singulars and plurals to the search sessions expiration badges.

| Scenario | Screenshot |
|----------|-------------|
| More than 1 day |
![image](https://github.com/user-attachments/assets/1935820f-80be-4748-864b-6bf4a9aa62ee)
|
| 1 day |
![image](https://github.com/user-attachments/assets/37ca52b5-8712-444f-bf04-ff2f43013583)
|
| More than 1 hour |
![image](https://github.com/user-attachments/assets/b000789f-2396-430d-a1a8-a398f183815c)
|
| 1 hour |
![image](https://github.com/user-attachments/assets/5af02abc-0a8c-492c-9e9f-2a0f16e6c8f2)
|
| 0 hours🙈 |
![image](https://github.com/user-attachments/assets/0b8cea3d-ab70-4059-a758-828df5f67a35)
|

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

(cherry picked from commit e5f374a)

# Conflicts:
#	src/plugins/data/public/search/session/sessions_mgmt/lib/get_expiration_status.test.ts
@AlexGPlay AlexGPlay requested a review from kibanamachine as a code owner July 9, 2025 13:21
@AlexGPlay AlexGPlay added the backport This PR is a backport of another PR label Jul 9, 2025
@AlexGPlay AlexGPlay enabled auto-merge (squash) July 9, 2025 13:21
@AlexGPlay AlexGPlay merged commit 713f8d6 into elastic:8.17 Jul 15, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants