Skip to content

[8.19] [chore] Bundle fp-ts into the shared bundle (#217034)#225428

Closed
dej611 wants to merge 6 commits intoelastic:8.19from
dej611:backport/8.19/pr-217034
Closed

[8.19] [chore] Bundle fp-ts into the shared bundle (#217034)#225428
dej611 wants to merge 6 commits intoelastic:8.19from
dej611:backport/8.19/pr-217034

Conversation

@dej611
Copy link
Copy Markdown
Contributor

@dej611 dej611 commented Jun 26, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@dej611
[chore] Bundle fp-ts into the shared bundle (elastic#217034)
c379792 
## Summary

Just had some fun and made fp-ts available in the shared bundle, with
support for partial imports.

Changes in this PR:
* aligned `fp-ts` direct imports to the format: `fp-ts/<module>`
* Mapped the direct imports into the shared bundle re-using the same
`fp-ts` module under the hood

(cherry picked from commit 0a6bc1b)

# Conflicts:
#	src/core/packages/saved-objects/migration-server-internal/src/actions/bulk_overwrite_transformed_documents.ts
#	src/core/packages/saved-objects/migration-server-internal/src/actions/create_index.ts
#	src/core/packages/saved-objects/migration-server-internal/src/actions/read_with_pit.ts
#	src/core/packages/saved-objects/migration-server-internal/src/actions/wait_for_task.ts
#	x-pack/solutions/observability/plugins/inventory/common/rt_types.ts
#	x-pack/solutions/security/plugins/security_solution/server/lib/timeline/saved_object/pinned_events/index.ts
@dej611 dej611 requested a review from kibanamachine as a code owner June 26, 2025 10:17
@dej611 dej611 added the backport This PR is a backport of another PR label Jun 26, 2025
@dej611 dej611 enabled auto-merge (squash) June 26, 2025 10:17
@dej611 dej611 mentioned this pull request Jun 26, 2025
Merged
@botelastic botelastic bot added Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Jun 26, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 26, 2025

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 26, 2025

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 10, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiAssistantManagementSelection 74 62 -12
apm 2055 2036 -19
cases 1152 1140 -12
cloudSecurityPosture 722 721 -1
console 253 252 -1
dataQuality 77 65 -12
datasetQuality 734 715 -19
discover 1480 1463 -17
esqlDataGrid 452 451 -1
eventAnnotationListing 610 609 -1
exploratoryView 170 159 -11
fieldsMetadata 57 45 -12
indexManagement 699 683 -16
infra 1795 1792 -3
ingestPipelines 358 337 -21
lens 1458 1457 -1
lists 488 462 -26
logsExplorer 480 468 -12
logsShared 383 371 -12
metricsDataAccess 305 293 -12
ml 2587 2570 -17
monitoring 853 836 -17
observability 1459 1439 -20
observabilityAIAssistantApp 458 446 -12
observabilityAiAssistantManagement 415 403 -12
observabilityLogsExplorer 542 534 -8
observabilityShared 344 332 -12
profiling 295 283 -12
searchprofiler 72 71 -1
securitySolution 7574 7548 -26
serverlessObservability 45 33 -12
slo 1333 1314 -19
stackConnectors 356 330 -26
streamsApp 496 484 -12
synthetics 1391 1365 -26
transform 837 820 -17
triggersActionsUi 1017 997 -20
upgradeAssistant 192 180 -12
uptime 919 893 -26
ux 188 176 -12
total -540

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ui-shared-deps-src 56 65 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 93.7KB 67.7KB -25.9KB
apm 2.7MB 2.6MB -50.1KB
cloudSecurityPosture 501.9KB 498.2KB -3.7KB
console 197.6KB 193.8KB -3.7KB
dataQuality 34.4KB 8.5KB -25.9KB
datasetQuality 440.3KB 400.9KB -39.4KB
discover 1.1MB 1.0MB -35.7KB
esqlDataGrid 160.4KB 156.7KB -3.7KB
exploratoryView 168.9KB 143.1KB -25.8KB
fieldsMetadata 80.4KB 54.4KB -26.0KB
indexManagement 742.8KB 704.2KB -38.6KB
infra 1.6MB 1.6MB -4.0KB
ingestPipelines 450.9KB 359.4KB -91.6KB
lists 182.6KB 114.4KB -68.2KB
logsExplorer 204.7KB 178.8KB -25.9KB
ml 5.5MB 5.5MB -32.0KB
monitoring 689.0KB 656.8KB -32.1KB
observability 1.3MB 1.3MB -43.8KB
observabilityAIAssistantApp 290.3KB 264.5KB -25.8KB
observabilityAiAssistantManagement 121.6KB 95.6KB -26.0KB
observabilityLogsExplorer 291.2KB 273.7KB -17.4KB
profiling 388.4KB 362.5KB -26.0KB
searchprofiler 46.7KB 43.0KB -3.7KB
securitySolution 9.4MB 9.3MB -68.0KB
slo 1010.9KB 993.5KB -17.4KB
stackConnectors 661.2KB 635.3KB -25.9KB
streamsApp 584.2KB 558.2KB -26.0KB
synthetics 1.0MB 1.0MB -17.4KB
transform 656.1KB 623.9KB -32.1KB
triggersActionsUi 1.5MB 1.5MB -44.3KB
upgradeAssistant 211.3KB 211.3KB +14.0B
uptime 511.0KB 493.6KB -17.4KB
ux 162.9KB 136.9KB -26.0KB
total -949.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
aiAssistantManagementSelection 5.3KB 5.4KB +47.0B
apm 33.7KB 33.8KB +114.0B
cases 161.5KB 135.6KB -25.8KB
cloudSecurityPosture 16.2KB 16.3KB +64.0B
console 28.0KB 28.0KB +47.0B
dataQuality 9.1KB 9.2KB +175.0B
datasetQuality 23.4KB 23.5KB +174.0B
discover 22.3KB 22.5KB +192.0B
esqlDataGrid 9.8KB 9.8KB +64.0B
exploratoryView 39.6KB 39.6KB +48.0B
fieldsMetadata 5.0KB 5.2KB +175.0B
indexManagement 31.3KB 31.4KB +168.0B
infra 48.4KB 48.5KB +81.0B
ingestPipelines 15.6KB 15.8KB +189.0B
kbnUiSharedDeps-npmDll 6.1MB 6.3MB ⚠️ +236.9KB
kbnUiSharedDeps-srcJs 3.7MB 3.7MB +64.0B
lists 4.3KB 4.5KB +241.0B
logsExplorer 24.2KB 24.4KB +177.0B
logsShared 155.4KB 129.5KB -25.9KB
ml 81.7KB 81.9KB +130.0B
monitoring 25.5KB 25.6KB +128.0B
observability 93.5KB 93.6KB +144.0B
observabilityAIAssistantApp 16.1KB 16.1KB +63.0B
observabilityAiAssistantManagement 5.9KB 5.9KB +13.0B
observabilityLogsExplorer 14.9KB 15.2KB +255.0B
observabilityShared 98.0KB 72.0KB -26.0KB
profiling 18.2KB 18.2KB +48.0B
searchprofiler 16.5KB 16.5KB +49.0B
securitySolution 85.8KB 86.0KB +262.0B
serverlessObservability 42.5KB 16.5KB -26.0KB
slo 57.7KB 31.9KB -25.7KB
stackConnectors 64.9KB 65.1KB +177.0B
streamsApp 10.5KB 10.5KB +48.0B
synthetics 53.3KB 27.5KB -25.8KB
transform 19.7KB 19.8KB +113.0B
triggersActionsUi 111.3KB 111.3KB -4.0B
upgradeAssistant 24.5KB 24.6KB +126.0B
uptime 68.4KB 42.6KB -25.8KB
ux 7.4KB 7.4KB +48.0B
total +59.4KB
Unknown metric groups

API count

id before after diff
@kbn/ui-shared-deps-src 65 74 +9

async chunk count

id before after diff
datasetQuality 17 15 -2
infra 38 34 -4
observability 25 24 -1
triggersActionsUi 59 57 -2
total -9

History

@dej611 dej611 closed this Nov 24, 2025
auto-merge was automatically disabled November 24, 2025 09:16

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

No one assigned

Labels

backport This PR is a backport of another PR Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dej611 @elasticmachine