[Security] Fix siemV3 migration for Endpoint Exceptions on Serverless#225331
Merged
gergoabraham merged 3 commits intoelastic:mainfrom Jun 25, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
paul-tavares
approved these changes
Jun 25, 2025
4 tasks
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Endpoint Exception ALL privilege got lost, because the original migration (PR: #219566) did this:
siem:ALLorsiemV2:ALL:global_artifact_management_all, becausesiemVXall meant that user can write Endpoint ExceptionssiemVX:ALLtosiemVX:MINIMAL_ALL, in order to enabled the sub-features toggle, so it is visible to the user that they are granted a new sub-privilegeand the issue: Endpoint Exceptions are not included in
siemVX:MINIMAL_ALL, and thanks to this the user lost their access to Endpoint Exceptions.this PR solves this issue.
visualization
with this change, the
siem/siemV2:ALL->siemV3migration graph now looks like this:flowchart LR classDef serverless stroke:blue,stroke-dasharray: 5 5 subgraph siemV2[siem/siemV2] all1[all] end subgraph siemV3 subgraph minall2[minimal_all] g1[global_artifact_management_all] eea["`endpoint_exceptions_all (only serverless)`"]:::serverless end end all1 -->|keep access to the included Endpoint Exceptions ALL| g1 all1 -->|enable sub-feature toggle| minall2 all1 -->|keep access to EE ALL, as it WAS included in ALL. only serverless| eea linkStyle 2 stroke:#00f,color:bluesee the previous ones here: #219566
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.