[6.x] [chrome/urlOverflowCheck] use modifyUrl helper (#22435)#22477
Merged
spalger merged 1 commit intoelastic:6.xfrom Aug 29, 2018
Merged
[6.x] [chrome/urlOverflowCheck] use modifyUrl helper (#22435)#22477spalger merged 1 commit intoelastic:6.xfrom
modifyUrl helper (#22435)#22477spalger merged 1 commit intoelastic:6.xfrom
Conversation
Fixes elastic#18835 This updates the url-overflow redirect to use the `modifyUrl()` helper which was written almost exclusively to help deal with the confusion that node's `path` and `pathname` nonsense creates. I tested this in Edge and things seem to work well, but I'd appreciate if @baracudda or @chandanpal could checkout this PR and see if it works for them.
Contributor
💚 Build Succeeded |
|
Still shows url-overflow under iexplorer11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x:
modifyUrlhelper ([chrome/urlOverflowCheck] usemodifyUrlhelper #22435)