Move security and spaces to platform#224464

Merged

fake-haris merged 13 commits intoelastic:mainfrom

fake-haris:move-apps-security-spaces-to-platform

Jun 20, 2025

Contributor

fake-haris commented Jun 18, 2025 •

edited by kibanamachine

Loading

Summary

Part of https://github.com/elastic/kibana-team/issues/1503

This PR relocates security and spaces test files from x-pack/test/functional/apps dir to x-pack/platform/test/functional/apps.

Before:

/x-pack/test/functional/apps
     | - security/
     | - spaces/

After:

/x-pack/platform/test/functional/apps
     | - security/
     | - spaces/

fake-haris added 6 commits

June 16, 2025 20:31


          moved security tests, role_mappings_page, security_page, user_menu

96c2406


          moved space_selector, ace_editor and spaces

ac5f17e


          updated services and page_objects, removed config_security_basic

98d6a5f


          enabled x-pack/test/functional/config.firefox.js

0095f37


          replaced configs in yml file

1df32f9


          update files in codeowners

909279b

fake-haris self-assigned this

fake-haris added Team:QA release_note:skip backport:version v9.1.0 v8.19.0 labels

fake-haris requested a review from dmlemeshko

June 18, 2025 15:56

dmlemeshko reviewed

View reviewed changes

x-pack/test/functional/page_objects/index.ts Show resolved Hide resolved

dmlemeshko reviewed

View reviewed changes

x-pack/test/functional/page_objects/index.ts Show resolved Hide resolved

fake-haris and others added 5 commits

June 19, 2025 09:42


          reverted page objects

379dcc6


          fixed check types errors

997f8b1


          [CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

e4d25b2

…-fix'


          changed config.base import from js to ts

da1fe66


          made config.base from js to ts

84ec3da

dmlemeshko reviewed

View reviewed changes

x-pack/platform/test/functional/apps/spaces/config.ts

               export default async function ({ readConfigFile }: FtrConfigProviderContext) {
-                const functionalConfig = await readConfigFile(require.resolve('../../config.base.js'));
+                const functionalConfig = await readConfigFile(require.resolve('../../config.base.ts'));

Contributor

dmlemeshko Jun 20, 2025

The config you load here is missing in directory causing linter to fail


x-pack/platform/test/functional/apps/spaces/config.ts
--
  | 2025-06-19 14:37:55 UTC | 11:65  error  Unable to resolve import [../../config.base.js]  @kbn/imports/no_unresolvable_imports

Afaik the config is in place, so maybe you need to remove .ts ? Please check it locally by running x-pack/platform/test/functional/apps/spaces/config.ts

Contributor Author

fake-haris Jun 20, 2025

Linting check passed after this change. CI is still running.

fake-haris marked this pull request as ready for review

June 20, 2025 08:35

fake-haris requested review from a team as code owners

June 20, 2025 08:35

Contributor

elasticmachine commented Jun 20, 2025

Pinging @elastic/appex-qa (Team:QA)

Contributor Author

fake-haris commented Jun 20, 2025

@elasticmachine merge upstream

Contributor

kibanamachine commented Aug 22, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

26 similar comments

Contributor

kibanamachine commented Aug 25, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Aug 26, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Aug 27, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Aug 28, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Aug 29, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 1, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 2, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 5, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 8, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 9, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 10, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 11, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 12, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 15, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 16, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 17, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 18, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 19, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 22, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 24, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 25, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 26, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 29, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Contributor

kibanamachine commented Sep 30, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224464 locally
cc: @fake-haris

Ikuni17 added backport:skip and removed backport missing backport:version labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip release_note:skip Team:QA v8.19.0 v9.1.0