Implement `LegacyService`. Use `core` to start legacy Kibana. by azasypkin · Pull Request #22190 · elastic/kibana

azasypkin · 2018-08-20T18:31:33Z

This PR implements LegacyService that will bridge core with "legacy" Kibana. And now core starts "legacy" Kibana!

How to test: everything should work as before, if you notice a difference - that's probably a bug.

~~Blocked by #21956~~
Unblocks #19994

Fixes #19324
Fixes #15888

elasticmachine · 2018-08-25T14:19:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

azasypkin · 2018-09-03T15:58:18Z

@spalger resolved conflicts, handled some comments and left questions for the others :)

spalger

Code is looking great, but I'm getting the following when running this locally:

~/kbn-dev/master/kibana (pr/22190) $ node scripts/kibana --dev
 watching for changes  (1735 files)
(node:39180) UnhandledPromiseRejectionWarning: Error: listen EADDRINUSE 127.0.0.1:5601
    at Object._errnoException (util.js:992:11)
    at _exceptionWithHostPort (util.js:1014:20)
    at Server.setupListenHandle [as _listen2] (net.js:1355:14)
    at listenInCluster (net.js:1396:12)
    at GetAddrInfoReqWrap.doListen (net.js:1505:7)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:97:10)
(node:39180) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:39180) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:39181) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
(node:39182) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.

update: Turns out this was caused by an SSH tunnel I had running on 5601, but it seems like an issue that this caused a bunch of unhandled promise rejections

spalger · 2018-09-05T23:37:43Z

src/cli/cluster/cluster_manager.js

    this.addedCount = 0;
    this.inReplMode = !!opts.repl;
+    this.basePathProxy = basePathProxy;
+    this.config = config;


Looks like we don't use this.config

👍 will remove it.

src/cli/serve/integration_tests/__snapshots__/invalid_config.test.js.snap

src/core/server/legacy_compat/legacy_service.ts

spalger · 2018-09-06T04:11:51Z

src/server/http/max_payload_size.test.js

-async function makeRequest(opts) {
-  return await kbnTestServer.makeRequest(kbnServer, opts);
-}
+}, 30000);


I'd say move it to integration tests, just not sure why it would take 16 seconds to start a server...

azasypkin · 2018-09-06T05:11:16Z

update: Turns out this was caused by an SSH tunnel I had running on 5601, but it seems like an issue that this caused a bunch of unhandled promise rejections

I believe this behavior was always like that, at least I see it in 6.3 and it's only related to the cluster manager that doesn't handle failures of the base path proxy, e.g. if I run node scripts/kibana --dev --server.port=9200 on 6.3 with ES already listening on 9200, I get:

$ node scripts/kibana --dev --server.port=9200
(node:29250) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
 watching for changes  (1502 files)
(node:29250) UnhandledPromiseRejectionWarning: Error: listen EADDRINUSE 127.0.0.1:9200
    at Object._errnoException (util.js:992:11)
    at _exceptionWithHostPort (util.js:1014:20)
    at Server.setupListenHandle [as _listen2] (net.js:1355:14)
    at listenInCluster (net.js:1396:12)
    at GetAddrInfoReqWrap.doListen (net.js:1505:7)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:97:10)
(node:29250) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:29250) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:29274) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
(node:29279) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.

You should see a much clearer message if Kibana main server fails because of the same reason either on 6.3/6.4/master or in this PR. Having said that we can eventually properly handle errors that are coming from the main cluster master process if we want to.

spalger

LGTM

…nd new `tutorial mixins` tests to the latest approach used by `test_utils\kbn_server`.

azasypkin · 2018-09-06T11:27:00Z

There is some flakiness in tests that I've touched (worker tests and new tutorial mixins), will figure that out. For the latter it's likely that Kibana server initialization takes more than 5 sec (I see locally it takes ~2.8-3.4s, with 95% of times spent on the LegacyService and await kbnServer.ready() in particular).

…from auto restart on shutdown.

azasypkin · 2018-09-06T14:11:10Z

Okay, in this particular case there is no reason to use full blown kibana server to test tutorial mixins so I modified the test to test mixin directly, should become green now.

But nevertheless I tried to figure out where kbn.ready spends most of the time and here are some not statistically significant results from a couple of my local test runs:

From a total of ~4.5s of Kibana server initialization ~1.77s were spent in sassMixin, ~1.2s in uiMixin and ~1.17s in uiRenderMixin. There is nothing to reason about here at this point, but now I have an idea where the problem can be.

elasticmachine · 2018-09-06T15:36:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

azasypkin · 2018-09-07T04:57:26Z

6.x/6.5: b076716

azasypkin added blocked Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Feature:New Platform v6.5.0 labels Aug 20, 2018

This was referenced Aug 20, 2018

[skip ci] Use new platform CLI as the main entry point #19994

Closed

Revamp core environment class to support upcoming core<-->legacy bootstrap inversion. #21885

Merged

azasypkin force-pushed the issue-xxx-core-legacy-service branch 2 times, most recently from de1c380 to 22d0f4e Compare August 22, 2018 10:22

azasypkin mentioned this pull request Aug 22, 2018

Upgrade Hapi in legacy platform to v17 #21707

Merged

azasypkin force-pushed the issue-xxx-core-legacy-service branch 7 times, most recently from a3bd81c to ab19b31 Compare August 24, 2018 08:41

azasypkin mentioned this pull request Aug 24, 2018

Make core responsible for reading and merging of config files. Simplify legacy config adapter. #21956

Merged

azasypkin changed the title ~~[skip ci] Implement LegacyService. Use core to start legacy Kibana.~~ Implement LegacyService. Use core to start legacy Kibana. Aug 24, 2018

azasypkin force-pushed the issue-xxx-core-legacy-service branch from ab19b31 to 3c03da9 Compare August 24, 2018 18:01

This comment has been minimized.

Sign in to view

azasypkin force-pushed the issue-xxx-core-legacy-service branch from 3c03da9 to f9103f3 Compare August 24, 2018 20:44

This comment has been minimized.

Sign in to view

azasypkin force-pushed the issue-xxx-core-legacy-service branch from f9103f3 to 5ce283a Compare August 24, 2018 23:54

This comment has been minimized.

Sign in to view

azasypkin force-pushed the issue-xxx-core-legacy-service branch from 5ce283a to d4f49aa Compare August 25, 2018 12:25

This comment has been minimized.

Sign in to view

azasypkin force-pushed the issue-xxx-core-legacy-service branch from d4f49aa to dbeae23 Compare August 25, 2018 12:38

azasypkin force-pushed the issue-xxx-core-legacy-service branch from dbeae23 to b8ecb64 Compare August 27, 2018 14:45

azasypkin requested a review from spalger September 3, 2018 15:58

azasypkin mentioned this pull request Sep 4, 2018

Get rid of __tests__ folders in the core/server. #22662

Merged

spalger reviewed Sep 6, 2018

View reviewed changes

spalger approved these changes Sep 6, 2018

View reviewed changes

azasypkin added 4 commits September 6, 2018 09:11

Merge branch 'master' into issue-xxx-core-legacy-service

93b52d7

Get rid of unused ClusterManager.config property.

9505607

Move legacy http tests tot the integration_tests suite. Migrate bra…

dc552dd

…nd new `tutorial mixins` tests to the latest approach used by `test_utils\kbn_server`.

Start Root only once before all tutorial mixins.

8dabf75

This comment has been minimized.

Sign in to view

Worker tests: set fork exit code to non-zero value to prevent worker …

403e868

…from auto restart on shutdown.

This comment has been minimized.

Sign in to view

azasypkin added 2 commits September 6, 2018 16:55

Do not rely on kbnServer when testing mixin.

e2afb1b

Merge branch 'master' into issue-xxx-core-legacy-service

af7db8f

azasypkin merged commit 3d6de7c into elastic:master Sep 6, 2018

azasypkin deleted the issue-xxx-core-legacy-service branch September 6, 2018 15:39

azasypkin added the backport pending label Sep 6, 2018

azasypkin mentioned this pull request Sep 6, 2018

[6.x] Implement LegacyService. Use core to start legacy Kibana. #22769

Merged

epixa mentioned this pull request Sep 6, 2018

Saved object migrations #20243

Merged

azasypkin added backported and removed backport pending labels Sep 7, 2018

epixa mentioned this pull request Sep 17, 2018

Config validation should occur up front #20303

Closed

azasypkin mentioned this pull request Sep 25, 2018

Native controllers #17496

Closed

mshustov mentioned this pull request Jun 17, 2019

New Platform and Legacy platform servers integration #39047

Merged

3 tasks

Conversation

azasypkin commented Aug 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

elasticmachine commented Aug 25, 2018

💚 Build Succeeded

Uh oh!

azasypkin commented Sep 3, 2018

Uh oh!

spalger left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spalger Sep 5, 2018

Choose a reason for hiding this comment

Uh oh!

azasypkin Sep 6, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

spalger Sep 6, 2018

Choose a reason for hiding this comment

Uh oh!

azasypkin commented Sep 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

azasypkin commented Sep 6, 2018

Uh oh!

This comment has been minimized.

azasypkin commented Sep 6, 2018

Uh oh!

elasticmachine commented Sep 6, 2018

💚 Build Succeeded

Uh oh!

azasypkin commented Sep 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

azasypkin commented Aug 20, 2018 •

edited

Loading

spalger left a comment •

edited

Loading

azasypkin commented Sep 6, 2018 •

edited

Loading