Merged
Conversation
22 tasks
Contributor
💚 Build Succeeded |
rhoboat
reviewed
Aug 8, 2018
| expect(schema.any().validate(true)).toBe(true); | ||
| expect(schema.any().validate(100)).toBe(100); | ||
| expect(schema.any().validate('foo')).toBe('foo'); | ||
| expect(schema.any().validate({ foo: 'bar', baz: 2 })).toEqual({ foo: 'bar', baz: 2 }); |
There was a problem hiding this comment.
This tests boolean, number, string, object. what about null and undefined? nevermind, we have undefined below. maybe just null?
Contributor
Author
There was a problem hiding this comment.
Yep, added a couple of expect's for null, thanks!
rhoboat
approved these changes
Aug 8, 2018
Contributor
💚 Build Succeeded |
Contributor
Author
|
6.x/6.5: 15e17aa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first of the PRs extracted from #19994. It introduces
schema.any(will be needed to pass legacy logging config of unknown shape to the legacy log appender that resides in the core).Unblocks #19994