Draft
Conversation
4d0a8e5 to
339f66c
Compare
b8cfd15 to
1d62bf1
Compare
Dosant
reviewed
Mar 11, 2025
| data-test-subj="esql-quick-reference" | ||
| onClick={() => toggleLanguageComponent()} | ||
| onClick={() => { | ||
| workspaceDispatch(openToolbox(WORKSPACE_TOOL_HELP)); |
Contributor
There was a problem hiding this comment.
qq: why should apps use API like this like this instead of:
core.workspace.openToolbox(WORKSPACE_TOOL_HELP)
This would also remove a new of
const WorkspaceStateProvider = services.core.chrome.workspace.getStateProvider(); in discover
Contributor
Author
There was a problem hiding this comment.
I really want to avoid bringing start contracts into our React code. It's always messy. I'd prefer just using Redux (or some abstraction thereof)... it's there and it's easy to understand. So that's why this PoC leans into just calling Redux.
1d62bf1 to
a21b87f
Compare
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
💔 Build Failed
Failed CI StepsHistory
|
Contributor
|
Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment. Details and writeup coming after demos/reviews.
cc: @ryankeairns @lukeelmers @ghudgins