Skip to content

[8.x] [Streams 🌊] Ensure the members array is unique for GroupStreamDefinitions (#210089)#211798

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-210089
Feb 20, 2025
Merged

[8.x] [Streams 🌊] Ensure the members array is unique for GroupStreamDefinitions (#210089)#211798
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-210089

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ions (elastic#210089)

## Summary

This PR ensures that the `definition.group.members` is a unique array of
strings. I introduced a new private function to the StreamsClient called
`parseDefinition` that will parse the definition being upserted with the
runtime schemas to ensure they are properly formatted. This is also a
good extension point for doing any transformations we need.

(cherry picked from commit a28e400)
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 19, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/config.ts / Alerting eventLog in space default should generate expected events for normal operation

Metrics [docs]

✅ unchanged

History

cc @simianhacker

@kibanamachine kibanamachine merged commit ae86aa6 into elastic:8.x Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants