[Spaces] - Update Roles screen to use public API#21031
Merged
legrego merged 3 commits intoelastic:spaces-phase-1from Jul 20, 2018
Merged
[Spaces] - Update Roles screen to use public API#21031legrego merged 3 commits intoelastic:spaces-phase-1from
legrego merged 3 commits intoelastic:spaces-phase-1from
Conversation
Contributor
💔 Build Failed |
Contributor
|
If you edit a role with a "Granted documents query", I'm seeing the toggle default to the wrong state. |
kobelb
reviewed
Jul 20, 2018
| }; | ||
|
|
||
| idPrefix = () => `${this.props.rbacApplication}_`; | ||
| idPrefix = () => `id_`; |
Contributor
There was a problem hiding this comment.
Do we still need the idPrefix? Does it come into play later?
Member
Author
There was a problem hiding this comment.
We may not -- I have another WIP branch that'll butcher a lot of this PR anyway. This is just a stopgap to get the form working again against the new API.
Contributor
|
I'm guessing the "Granted documents query" behavior was likely here before this PR, so if you'd like to fix this in another PR, then LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the new Role Management screen to use the public role API introduced as part of #20732.
Additionally, this updates the breadcrumb nav for Spaces and Role management screens to be consistent with the nav introduced in #20739.
There are a couple of visual glitches in this PR which are a result of current defects on master, so they can be safely ignored for the time being.