[6.x] Reactify users roles (#20739)#21028
Merged
bmcconaghy merged 1 commit intoelastic:6.xfrom Jul 20, 2018
Merged
Conversation
* partial progress on reactifying users * progress on EUIfication of users screen * removing Angular stuff * adding data-test-subj="passwordConfirmationInput" * removing data-test-subj="userFormEmailInput" refs from tests * fixing selector for role assignment * some functional test fixes * fixing some functional tests * fixing last functional test * removing stray console log * fixing warnings * attempting to fix flaky test * trying again to fix flaky test * PR feedback * PR feedback * fixing issue where form tried to submit * adding sleep to allow user to load * Design edits Mainly adding wrapper EUI page elements, but also shifted around form elements. * Fixed console error and added responsive prop to table * addressing PR feedback * A few more PR feedback - Fixed alignment of table - Removed the tooltip from the lock icon and placed the description inline. - Changed delete button to an empty button * addressing more PR feedback * adding email field back in * adding back username validation * restoring original error message * fixing dumb null error
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x: