[8.18] [ Security Solution ] Fix Refetch logic with new timeline batching (#205893)#210009
Closed
logeekal wants to merge 1 commit intoelastic:8.18from
Closed
[8.18] [ Security Solution ] Fix Refetch logic with new timeline batching (#205893)#210009logeekal wants to merge 1 commit intoelastic:8.18from
logeekal wants to merge 1 commit intoelastic:8.18from
Conversation
…lastic#205893) ## Summary PR : elastic#204034 fixed some issues with timeline batching. It was not able to fix one of the issue with `Refetch` logic which exists in `main` ( resulting in a flaky test ) and causing some tests to fail in `8.16`, `8.17` and `8.x`. ## Issue Description There are 2 issues with below video: 1. When user updates a status of an alert, the `Refetch` only happens on the first `batch`. This behaviour is flaky currently. Even if the user is on nth batch, table will fetch 0th batch and reset the user's page back to 1. https://github.com/user-attachments/assets/eaf88a82-0e9b-4743-8b2d-60fd327a2443 3. When user clicks `Refresh` manually, then also only first (0th) `batch` is fetched, which should have rather fetched all the present batches. https://github.com/user-attachments/assets/8d578ce3-4f24-4e70-bc3a-ed6ba99167a0 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 54b4fac) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/timelines/containers/index.test.tsx # x-pack/solutions/security/plugins/security_solution/public/timelines/containers/index.tsx
1 task
Contributor
💔 Build Failed
Failed CI StepsHistory |
auto-merge was automatically disabled
February 6, 2025 15:07
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.18:Questions ?
Please refer to the Backport tool documentation
\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Jatin Kathuria "}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/205893","number":205893,"mergeCommit":{"message":"[ Security Solution ] Fix Refetch logic with new timeline batching (#205893)\n\n## Summary\n\nPR : https://github.com//pull/204034 fixed some issues\nwith timeline batching. It was not able to fix one of the issue with\n`Refetch` logic which exists in `main` ( resulting in a flaky test ) and\ncausing some tests to fail in `8.16`, `8.17` and `8.x`.\n\n## Issue Description\n\nThere are 2 issues with below video:\n\n1. When user updates a status of an alert, the `Refetch` only happens on\nthe first `batch`. This behaviour is flaky currently. Even if the user\nis on nth batch, table will fetch 0th batch and reset the user's page\nback to 1.\n\n\n\nhttps://github.com/user-attachments/assets/eaf88a82-0e9b-4743-8b2d-60fd327a2443\n \n\n\n3. When user clicks `Refresh` manually, then also only first (0th)\n`batch` is fetched, which should have rather fetched all the present\nbatches.\n\n\n\n\nhttps://github.com/user-attachments/assets/8d578ce3-4f24-4e70-bc3a-ed6ba99167a0\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"54b4fac705c231b52396d70906f3259f9b129a3b"}},{"url":"https://github.com//pull/205676","number":205676,"branch":"8.17","state":"OPEN"},{"url":"https://github.com//pull/205702","number":205702,"branch":"8.x","state":"MERGED","mergeCommit":{"sha":"e480de112ae6bc121c4415e2e1726dd551805672","message":"[8.x] [Security Solution] Fix timeline dynamic batching (#204034) (#205702)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Security Solution] Fix timeline dynamic batching\n(#204034)](https://github.com//pull/204034)\n - https://github.com//pull/205893\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\n---------\n\nCo-authored-by: Philippe Oberti \nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>"}},{"url":"https://github.com//pull/205674","number":205674,"branch":"8.16","state":"OPEN"}]}] BACKPORT-->