[6.x] Provide InputRange component valid value when Range slider is not set. (#20002)#20735
Merged
nreese merged 1 commit intoelastic:6.xfrom Jul 12, 2018
Merged
Conversation
elastic#20002) * move unsetLogic into react component * remove extra comment * add comment about why empty state is needed for InputRange component * fix broken jest test * move empty state logic from react component to ListControl class, add comments about reset and clear functions * add comments about clear and reset to control class * calculate hasChanged to avoid bug where clear form still shows 'cancel changes' as active for an empty form * use hasValue in range control to check if value exists * add unit test for list_control_factory and cleanup range_control from review comments
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x: