[8.x] make emotion typing global (#200958)#203162
Merged
kibanamachine merged 1 commit intoelastic:8.xfrom Dec 5, 2024
Merged
Conversation
## Summary Informed by elastic/eui#6828 (comment), closes elastic/kibana-team#1299 This PR consolidates typings to provide adequate typing for the `css` prop EUI components accept. Placing the required typing file in the typing directory means that all other plugins that already reference this directory in their `tsconfig.json` would get this improvement by default. <!-- ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --> (cherry picked from commit c5cc153)
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
⏳ Build in-progress
cc @eokoneyo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation
","sha":"c5cc1532d74e8d733f57329959253e698105b447","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"make emotion typing global","number":200958,"url":"https://github.com//pull/200958","mergeCommit":{"message":"make emotion typing global (#200958)\n\n## Summary\r\n\r\nInformed by\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-11247425,\r\ncloses https://github.com/elastic/kibana-team/issues/1299\r\n\r\nThis PR consolidates typings to provide adequate typing for the `css`\r\nprop EUI components accept. Placing the required typing file in the\r\ntyping directory means that all other plugins that already reference\r\nthis directory in their `tsconfig.json` would get this improvement by\r\ndefault.\r\n\r\n","sha":"c5cc1532d74e8d733f57329959253e698105b447"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/200958","number":200958,"mergeCommit":{"message":"make emotion typing global (#200958)\n\n## Summary\r\n\r\nInformed by\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-11247425,\r\ncloses https://github.com/elastic/kibana-team/issues/1299\r\n\r\nThis PR consolidates typings to provide adequate typing for the `css`\r\nprop EUI components accept. Placing the required typing file in the\r\ntyping directory means that all other plugins that already reference\r\nthis directory in their `tsconfig.json` would get this improvement by\r\ndefault.\r\n\r\n","sha":"c5cc1532d74e8d733f57329959253e698105b447"}}]}] BACKPORT-->