Skip to content

[6.x] Replace spy panels by Inspector (#16387) | Fix one inspector test (#20072)#20076

Merged
timroes merged 6 commits intoelastic:6.xfrom
timroes:backport/6.x/pr-16387_pr-20072
Jun 21, 2018
Merged

[6.x] Replace spy panels by Inspector (#16387) | Fix one inspector test (#20072)#20076
timroes merged 6 commits intoelastic:6.xfrom
timroes:backport/6.x/pr-16387_pr-20072

Conversation

@timroes
Copy link
Copy Markdown
Contributor

@timroes timroes commented Jun 20, 2018

Backports the following commits to 6.x:

timroes added 3 commits June 20, 2018 14:15
* Add Inspector feature

* So long, and thanks for all the fish, spy panel

* Fix several functional tests

* Fix unit tests

* Fix spy panel button tests

* Replace old spy panel documentation

* Disable test temporarily until we have dashboard triggers

* Enter edit mode for dark theme test

* Fix some more functional tests

* Fix more functional tests

* More test fixing

* Fix more functional tests

* Allow opening the inspector via loader handler

* Refactor InspectorViewChooser, remove unused CSS

* Remove dead code

* Fix data download button style

* Remove redundant code

* Load inspectorViews for dashboard_viewer

* Extract inspector views to custom core_plugin

* Switch API to TypeScript 🎉

* Design changes

* Remove icons from views

* Design changes

* Improve typings of API

* Add typing to all adapters

* Show loading spinner in request selector

* Rewrite InspectorView to TypeScript

* Fix help text for data view

* Remove deprecated React lifecycle methods

* Embed inspector into dashboard panel actions

* Remove temporary inspector trigger

* Remove old CSS

* Fix dashboard trigger for new panel action

* Add tests for InspectorPanel and DataAdapter

* Produce a hierarchical table if the vis is hierarchical

* Remove allowJs option again

* Add missing Apache license headers

* Close inspector on dashboard when navigating away

* Use proper title for dashboard panels

* Fix functional tests

* Skip broken test for now

* Flush view chooser button

* Add request adapter tests

* Skip more tests, broken due to typescript

* Add Request Time description

* Add description for courier request

* Fix tests

* Replace icon by new (not yet released) icon

* Finalize design of inspector

* Remove discover test, that relied on spy panels

* Change API to be properly mockable in tests

* Add aria-live region for request status

* Replace old method in functional tests

* Replace abitrary magic number

* Use object destructuring in vis

* Fix issue with crashing requests view

* Add request time tooltip

* Get request body of correct search source

* Make filter buttons properly keyboard accessible

* Follow Dave's design suggestions

* Remove redundant request from name

* Remove unneeded comments

* WIP raw-formatted values

* Fix filtering issue

* Fix tests and more license headers

* Add data view tests

* Remove search from table

* Fix typos

* Implement review suggestion

* Remove artificial delays for testing

* Fix new panel action structure

* Minor design adjustments

* Fix failing functional test

* Update failing snapshot test

* Implement final wording

* Apply new EUI styling

* Fix closing inspector in tests

* Fix sorting of table

* Align punctuation between tooltips
@timroes timroes added backport This PR is a backport of another PR v6.4.0 labels Jun 20, 2018
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@timroes
Copy link
Copy Markdown
Contributor Author

timroes commented Jun 20, 2018

Jenkins, test this

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@timroes
Copy link
Copy Markdown
Contributor Author

timroes commented Jun 20, 2018

Jenkins, test this

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@timroes timroes merged commit 9ba0689 into elastic:6.x Jun 21, 2018
@timroes timroes deleted the backport/6.x/pr-16387_pr-20072 branch June 21, 2018 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR v6.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants