Skip to content

[8.x] [ES|QL] separate `KEEP`, `DROP`, and `SORT` autocomplete routines (#197744)#198159

Merged
kibanamachine merged 2 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-197744
Oct 30, 2024
Merged

[8.x] [ES|QL] separate `KEEP`, `DROP`, and `SORT` autocomplete routines (#197744)#198159
kibanamachine merged 2 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-197744

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

@kibanamachine kibanamachine commented Oct 29, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@drewdaemon @elasticmachine
[ES|QL] separate KEEP, DROP, and SORT autocomplete routines (el…
59a7a3e 
…astic#197744)

## Summary

This PR begins the refactor described in
elastic#195418.

The autocomplete engine now delegates to command-specific routines
attached to the command definitions for `KEEP`, `DROP`, and `SORT`.

The naming of `getFieldsFor` has been broadened to `getColumnsFor`
because the response from Elasticsearch can contain variables as well as
fields, depending on the query that is used to fetch the columns.

No user-facing behavior should have changed.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 11ae6a5)
@kibanamachine kibanamachine requested a review from a team as a code owner October 29, 2024 15:57
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 29, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) October 29, 2024 15:57
@kibanamachine kibanamachine mentioned this pull request Oct 29, 2024
Merged
1 task
@kibanamachine kibanamachine merged commit d4b1e28 into elastic:8.x Oct 30, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 30, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6131 6134 +3
unifiedSearch 356 359 +3
total +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 180.5KB 180.5KB +1.0B
securitySolution 20.5MB 21.0MB ⚠️ +511.9KB
total +511.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.4MB 3.4MB +1.1KB
Unknown metric groups

References to deprecated APIs

id before after diff
@kbn/monaco 4 5 +1

Unreferenced deprecated APIs

id before after diff
@kbn/esql-validation-autocomplete 0 1 +1

cc @drewdaemon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@drewdaemon drewdaemon

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kibanamachine @elasticmachine @drewdaemon @stratoula