Skip to content

[8.x] Execution type field (#195884)#196152

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-195884
Oct 14, 2024
Merged

[8.x] Execution type field (#195884)#196152
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-195884

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Added new field - execution type for alerts

Added new field only for security type alerts:

`kibana.alert.rule.execution.type` - can be `manual` or `scheduled`

Also, move intended timestamp settings from
`create_persistence_rule_type_wrapper` to `build_alert`

Also added those new field to Alert schema and types.

https://github.com/user-attachments/assets/c5b021a6-4763-47ae-b46c-814a138be65a

For tests:

- tests all rule types with and without suppression:
`kibana.alert.rule.execution.type` - should be `scheduled`,
`kibana.alert.intended_timestamp` - should equal alert timestamp

- tests all rules with and without suppression with manual run -
`kibana.alert.rule.execution.type` - should be `manual`,
`kibana.alert.intended_timestamp` - should equal date inside you manual
rule run date range

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 3d466a7)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 14, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) October 14, 2024 14:34
@kibanamachine kibanamachine merged commit eca46fe into elastic:8.x Oct 14, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/rule-data-utils 126 127 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
investigateApp 483.3KB 483.4KB +69.0B
observability 468.1KB 468.2KB +44.0B
securitySolution 20.8MB 20.8MB +278.0B
slo 855.3KB 855.3KB +44.0B
synthetics 1.2MB 1.2MB +45.0B
total +480.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 103.7KB 103.8KB +58.0B
slo 24.7KB 24.8KB +58.0B
synthetics 37.1KB 37.1KB +58.0B
total +174.0B
Unknown metric groups

API count

id before after diff
@kbn/rule-data-utils 129 130 +1

cc @nkhristinin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants