Skip to content

[deploy-fix@1728886420] [Onboarding] only update the index details page when plugin is enabled (#196077)#196136

Merged
pheyos merged 1 commit intoelastic:deploy-fix@1728886420from
joemcelroy:backport/deploy-fix@1728886420/pr-196077
Oct 14, 2024
Merged

[deploy-fix@1728886420] [Onboarding] only update the index details page when plugin is enabled (#196077)#196136
pheyos merged 1 commit intoelastic:deploy-fix@1728886420from
joemcelroy:backport/deploy-fix@1728886420/pr-196077

Conversation

@joemcelroy
Copy link
Copy Markdown
Member

Backport

This will backport the following commits from main to deploy-fix@1728886420:

Questions ?

Please refer to the Backport tool documentation

elastic#196077)

## Summary

The index details page is always updated even when the plugin is
disabled. Using the pluginEnabled conditional to only update when
enabled.

### How to replicate
1. disable uisetting for search indices plugin
2. go to index management and click on a index detail

Expected: see the old index detail page
actual: goes to the new index detail url but does not render the search
detail page (as plugin disabled)

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit efab00b)
@joemcelroy joemcelroy requested a review from a team as a code owner October 14, 2024 13:19
@joemcelroy joemcelroy added the backport This PR is a backport of another PR label Oct 14, 2024
@joemcelroy joemcelroy enabled auto-merge (squash) October 14, 2024 13:19
@pheyos pheyos disabled auto-merge October 14, 2024 13:46
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchIndices 7.2KB 7.3KB +22.0B

@pheyos pheyos merged commit f693226 into elastic:deploy-fix@1728886420 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants