Skip to content

[8.x] [ResponseOps][Alerting] Error when submit rule form when using AddFilterPopover in actions (#194600)#195228

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-194600
Oct 7, 2024
Merged

[8.x] [ResponseOps][Alerting] Error when submit rule form when using AddFilterPopover in actions (#194600)#195228
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-194600

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…terPopover in actions (elastic#194600)

Resolve: elastic#192847

When user try to save the rule which has a conditional action with a
filter which contains AND or OR, it'll fail.
Error raises when a new rule SO object is going to be created.
Validation fails because schema is wrong.
I fixed it in this PR.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### How to test

1. Go to Rules and try creating a new rule of any type
2. Add an action to the rule
3. Check the option If alert matches a query
4. Click the + icon to add a filter
5. Create a filter in the popover
6. Click AND or OR
7. Create another filter
8. Click Add filter
9. Try saving the rule
10. Saving should be successful

(cherry picked from commit 02d0c98)
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 123.3KB 123.3KB +19.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @guskovaue

@kibanamachine kibanamachine merged commit c3012d8 into elastic:8.x Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants