Skip to content

[8.x] [Lens] Corrects incorrect copy for line chart & fix flaky test (#192734)#193347

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-192734
Sep 18, 2024
Merged

[8.x] [Lens] Corrects incorrect copy for line chart & fix flaky test (#192734)#193347
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-192734

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ic#192734)

## Summary
Corrects incorrect copy for line chart.

Rewrites some of the tests to rtl.
Unskips flaky or failing tests.
Fixes elastic#192476
Removes some errors from the console that appear during unit test
running.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit e1db296)
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / Create renders correctly with optional fields
  • [job] [logs] Jest Tests #10 / DeleteConfirmationModal calls onConfirm

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB -802.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mbondyra

@kibanamachine kibanamachine merged commit 3a62655 into elastic:8.x Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants