fix: [Obs Infrastructure > Hosts][KEYBOARD]: Host flyout has buggy scrolling when I expand the State dropdown menu#192372
Merged
alexwizp merged 9 commits intoelastic:mainfrom Sep 29, 2024
Merged
Conversation
…rolling when I expand the State dropdown menu Closes: elastic/observability-accessibility#98
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
Author
|
Hi @elastic/obs-ux-infra_services-team Could you please review the new UX after removing the |
Contributor
Author
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/elastic/observability-accessibility/issues/98
Description
The Obs Applications > Hosts > Host popout menu has a buggy keyboard navigation behavior when I expand the
Statedropdown. If I pressDown_Arrowbefore tabbing into the State dropdown, the entire page scrolls. This feels like a bug because I was not expecting the page to shift. It creates an unexpected scroll event, so treating it as a keyboard nav bug. I've attached an MOV file to show the behavior.Steps to recreate
Processestab in the flyoutEnterDown_Arrowto see the entire page scroll, but not the State menu optionsTabto "drop into" the State menuDown_Arrowagain to see the menu scroll correctlyWhat was changed?:
ownFocus={false}fromEuiFlyout. This restores the default user experience (UX) forEuiFlyoutand resolves the mentioned issue.