Skip to content

[Controls] Fix styles#192319

Merged
andreadelrio merged 9 commits intoelastic:mainfrom
andreadelrio:controls-es
Sep 11, 2024
Merged

[Controls] Fix styles#192319
andreadelrio merged 9 commits intoelastic:mainfrom
andreadelrio:controls-es

Conversation

@andreadelrio
Copy link
Copy Markdown
Contributor

@andreadelrio andreadelrio commented Sep 8, 2024 •
edited
Loading

Summary

Closes #192229

Frame 547

Changes

  • Fixes padding in the prepend in all control types, in both modes (i.e. view and edit) and in both label positions (i.e. inline and above)
  • Removes the empty icon in view mode introduced by [Controls] Prevent jumping control drag handle between view modes #184533. After thinking about this is some more I think this is unnecessary given the shift in the UI that already exists for Dashboards when switching back and forth between View and Edit Mode.
  • For better control, this creates and passes custom class names to controlFrame__formControlLayout.

Note

We will be able to do a further clean up these styles when we are done with #192005.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@andreadelrio andreadelrio requested review from a team as code owners September 8, 2024 01:43
@andreadelrio
Copy link
Copy Markdown
Contributor Author

andreadelrio commented Sep 8, 2024

@elasticmachine merge upstream

@andreadelrio andreadelrio added the release_note:skip Skip the PR/issue when compiling release notes label Sep 8, 2024
@Heenawter Heenawter self-requested a review September 9, 2024 13:48
Heenawter
Heenawter reviewed Sep 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Heenawter Heenawter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for the new React controls!! 🎉 Seems like some of the css changes are impacting the controls on Dashboard, though - there is extra padding in both edit mode and view mode on the left of the label text:

Main This PR
image image
image image

So, we can either (a) wait until #192221 and #190561 are merged to merge this change or (b) try to make these changes without impacting the old controls.

@andreadelrio
Copy link
Copy Markdown
Contributor Author

andreadelrio commented Sep 9, 2024

This works great for the new React controls!! 🎉 Seems like some of the css changes are impacting the controls on Dashboard, though - there is extra padding in both edit mode and view mode on the left of the label text:

Main This PR
image image
image image
So, we can either (a) wait until #192221 and #190561 are merged to merge this change or (b) try to make these changes without impacting the old controls.

My vote is to wait until #192221 and #190561 are merged.

@Heenawter
Copy link
Copy Markdown
Contributor

Heenawter commented Sep 10, 2024

@andreadelrio This should be good to merge now 🎉 🎉 🎉

@andreadelrio
Copy link
Copy Markdown
Contributor Author

andreadelrio commented Sep 10, 2024

@elasticmachine merge upstream

Heenawter
Heenawter approved these changes Sep 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized that, in the original compressed PR, we missed the fact that the "apply" button should also be compressed 😅

image

Would you mind fixing that here @andreadelrio? If not, I can make a quick follow up.

Other than that, this LGTM 👍 The above issue is technically unrelated, so approving to unblock. Just LMK.

@andreadelrio
Copy link
Copy Markdown
Contributor Author

andreadelrio commented Sep 10, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 11, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 595.3KB 597.0KB +1.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andreadelrio andreadelrio merged commit 05c9bbe into elastic:main Sep 11, 2024
@kibanamachine kibanamachine added v8.16.0 backport:skip This PR does not require backporting labels Sep 11, 2024
@szaffarano szaffarano mentioned this pull request Sep 13, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nreese nreese nreese left review comments

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@Heenawter Heenawter Heenawter approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Controls] Fix left padding in view mode

7 participants

@andreadelrio @Heenawter @kibana-ci @nreese @MichaelMarcialis @kibanamachine @elasticmachine