Skip to content

[Spaces] Create Default Space on startup#19177

Merged
legrego merged 7 commits intoelastic:spaces-phase-1from
legrego:create-default-space
May 21, 2018
Merged

[Spaces] Create Default Space on startup#19177
legrego merged 7 commits intoelastic:spaces-phase-1from
legrego:create-default-space

Conversation

@legrego
Copy link
Copy Markdown
Member

@legrego legrego commented May 17, 2018

When Kibana starts, a Default Space will be created if one does not already exist. The Default Space will contain all objects that are not currently assigned to any other space (i.e., objects created prior to Spaces being enabled, or objects created directly within the Default Space).

To enable this, this PR also introduces the concept of Reserved Spaces, which is denoted by a _reserved property on the space object. Reserved Spaces:

  1. Cannot be deleted
  2. Cannot have their URL Context Changed

This PR does not address:

  1. Disabling the UI for reserved roles - this will be enabled via [Spaces] - Reactify roles screen #19035 once this PR is merged into it.

@legrego legrego added WIP Work in progress Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// labels May 17, 2018
@legrego legrego removed the WIP Work in progress label May 17, 2018
@legrego legrego requested a review from kobelb May 17, 2018 19:36
Copy link
Copy Markdown
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,98 @@
/*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@legrego legrego merged commit 7db020e into elastic:spaces-phase-1 May 21, 2018
@legrego legrego deleted the create-default-space branch April 29, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants