upgrade to react 18 by eokoneyo · Pull Request #191385 · elastic/kibana

eokoneyo · 2024-08-27T08:08:44Z

Summary

Upgrade React (react, react-dom) to v18
Also upgrades react-test-renderer to support react v18

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

packages/kbn-test/src/jest/run.ts

eokoneyo · 2024-09-11T09:42:30Z

/ci

eokoneyo · 2024-09-11T10:40:47Z

/ci

eokoneyo · 2024-09-11T14:23:36Z

/ci

kibana-ci · 2024-09-11T14:56:44Z

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

[job] [logs] Jest Tests #2 / should call assignees update functionality with the right arguments
[job] [logs] Jest Tests #16 / EKS Credentials input fields renders cloudbeat/cis_eks Direct Access Keys fields
[job] [logs] Jest Integration Tests #7 / request flyout renders _meta field
[job] [logs] Jest Integration Tests #7 / request flyout renders a json with default policy name when only policy name is missing
[job] [logs] Jest Integration Tests #7 / request flyout renders an error callout if policy form is invalid
[job] [logs] Jest Integration Tests #7 / request flyout renders the correct json and name for a new policy
[job] [logs] Jest Tests #11 / should call onUsersChange on closing the popover
[job] [logs] FTR Configs #29 / a11y tests using flights sample data Dashboard Delete a11y clone dashboard
[job] [logs] Jest Tests #12 / action_type_form shows an error icon when there is a form error and the action accordion is closed
[job] [logs] Jest Tests #14 / ActionForm - Slack API Connector show error message when no channel has been selected
[job] [logs] Jest Tests #12 / ActionsConnectorsHome renders Actions connectors list component
[job] [logs] Jest Tests #4 / AssistantOverlay should not render the header link if not authorized
[job] [logs] FTR Configs #85 / Canvas Canvas app expression editor "before all" hook for "updates when element is changed via side bar"
[job] [logs] FTR Configs #85 / Canvas Canvas app expression editor "before all" hook for "updates when element is changed via side bar"
[job] [logs] Jest Tests #12 / Connector rules list renders correctly
[job] [logs] Jest Tests #12 / ConnectorForm calls onChange when the form is invalid
[job] [logs] Jest Tests #12 / ConnectorForm registers the pre submit validator correctly
[job] [logs] Jest Tests #12 / ConnectorFormFields shows the connector fields
[job] [logs] FTR Configs #7 / Console App CCS Perform CCS Search in Console it should be able to access remote data
[job] [logs] FTR Configs #55 / console app console app should return statusCode 400 to unsupported HTTP verbs
[job] [logs] Jest Tests #14 / ContainerMetricsTable createLazyContainerMetricsTable should lazily load and render the table
[job] [logs] Jest Tests #2 / Custom Dashboards Actions should render the unlink dashboard action when the user can unlink a dashboard
[job] [logs] Jest Tests #2 / Custom Dashboards Actions should render the unlink dashboard action when the user cannot unlink a dashboard
[job] [logs] FTR Configs #51 / dashboard app - group 4 dashboard listing page search does not match mid word
[job] [logs] FTR Configs #42 / dashboard Reporting Dashboard Reporting Screenshots Sample data from Kibana 7.6 "before all" hook for "PNG file matches the baseline image"
[job] [logs] FTR Configs #36 / dashboard sample data dashboard should launch sample flights data set dashboard
[job] [logs] FTR Configs #36 / dashboard sample data dashboard should launch sample flights data set dashboard
[job] [logs] FTR Configs #70 / Dashboard save a search sessions with relative time Saves and restores a session with relative time ranges
[job] [logs] Jest Tests #11 / DashboardPanelSelectionListFlyout renders a not found message when a user searches for an item that is not in the selection list
[job] [logs] Jest Tests #11 / DashboardPanelSelectionListFlyout renders the list of available panels when fetchDashboardPanel resolves a value
[job] [logs] Jest Tests #12 / DiscoverMainRoute renders no data page when hasESData=false & hasUserDataView=false
[job] [logs] Jest Tests #12 / DiscoverMainRoute renders no data view when hasESData=true & hasUserDataView=false
[job] [logs] Jest Tests #12 / DiscoverTopNavInline LogsExplorerTabs should render when showLogsExplorerTabs is true
[job] [logs] Jest Tests #1 / dynamic should accept an optional "fallback" node to display while loading the component
[job] [logs] Jest Tests #1 / dynamic should create a lazy loaded component starting from a dynamic default import
[job] [logs] Jest Tests #1 / dynamic should create a lazy loaded component starting from a dynamic named import
[job] [logs] Jest Tests #1 / dynamic the created lazy loaded component should forward the ref property if provided
[job] [logs] Jest Tests #12 / EditConnectorFlyout Submitting runs pre submit validator correctly
[job] [logs] Jest Tests #3 / EntryContent should render a nested value
[job] [logs] FTR Configs #38 / Execution context Browser apps dashboard app "before all" hook in "dashboard app"
[job] [logs] Jest Tests #10 / FilterGroup handles loading
[job] [logs] Jest Tests #11 / FilterLabel should delete filter
[job] [logs] Jest Tests #11 / FilterLabel should invert filter
[job] [logs] Jest Tests #11 / FilterLabel should render properly
[job] [logs] Jest Tests #10 / FiltersExpressionSelect contains provided new filter values
[job] [logs] Jest Tests #11 / FilterValueButton should force open nested
[job] [logs] Jest Tests #12 / home renders rule list components
[job] [logs] Jest Tests #14 / HostMetricsTable createLazyHostMetricsTable should lazily load and render the table
[job] [logs] FTR Configs #37 / lens app - group 4 show underlying data should show the underlying data extracting all filters and columns from a formula
[job] [logs] FTR Configs #11 / lens app - group 5 lens drag and drop tests dropping between layers should move formula to empty dimension
[job] [logs] FTR Configs #28 / lens app - group 6 lens disable auto-apply tests should apply changes when "Apply" is clicked
[job] [logs] FTR Configs #28 / lens app - group 6 lens disable auto-apply tests should apply changes when "Apply" is clicked
[job] [logs] FTR Configs #65 / machine learning - data visualizer esql data visualizer with farequote ES|QL farequote displays index details
[job] [logs] FTR Configs #14 / machine learning - permissions for user with read ML access with data loaded (ft_ml_viewer) should display elements on Calendar management page correctly
[job] [logs] FTR Configs #17 / machine learning - short tests settings calendar creation calendars connected by job groups should only be automatically connected to job groups applied during creation and can be applied to job groups after creation
[job] [logs] FTR Configs #77 / maps app embeddable Map embeddable in canvas "before all" hook for "should render map embeddable"
[job] [logs] FTR Configs #77 / maps app embeddable Map embeddable in canvas "before all" hook for "should render map embeddable"
[job] [logs] FTR Configs #104 / maps app maps loaded from sample data ecommerce "before all" hook for "should load layers"
[job] [logs] FTR Configs #60 / maps app mvt geotile grid layer should render with mvt-source (style meta from ES)
[job] [logs] FTR Configs #64 / Monitoring app Elasticsearch nodes listing with only online nodes should filter for specific indices
[job] [logs] Jest Tests #15 / OpenTimelineButton should open the modal after clicking on the button
[job] [logs] Jest Tests #14 / PodMetricsTable createLazyPodMetricsTable should lazily load and render the table
[job] [logs] Jest Tests #16 / ranges paramEditor Specify range intervals manually should add a new range
[job] [logs] Jest Tests #16 / ranges paramEditor Specify range intervals manually should add a new range with custom label
[job] [logs] Jest Tests #16 / ranges paramEditor Specify range intervals manually should open a popover to edit an existing range
[job] [logs] Jest Tests #3 / renderApp Enterprise Search apps renders EnterpriseSearchOverview
[job] [logs] Jest Tests #15 / ResizableLayout should render without any issues
[job] [logs] Jest Tests #12 / rule_add renders selection of rule types to pick in the modal
[job] [logs] FTR Configs #30 / Sanity checks lens app lens formula tests should allow creation of a lens chart via formula
[job] [logs] FTR Configs #96 / Sanity checks lens app lens formula tests should allow creation of a lens chart via formula
[job] [logs] FTR Configs #63 / saved objects tagging - functional tests table listing searching allows to search by name
[job] [logs] FTR Configs #63 / saved objects tagging - functional tests table listing searching allows to search by name
[job] [logs] FTR Configs #85 / security app dls "after all" hook: logout for "user East should only see EAST doc"
[job] [logs] FTR Configs #85 / security app dls "after all" hook: logout for "user East should only see EAST doc"
[job] [logs] FTR Configs #85 / security app dls should add new role myroleEast
[job] [logs] FTR Configs #85 / security app dls should add new role myroleEast
[job] [logs] Jest Tests #11 / SelectedFilters should render properly
[job] [logs] Jest Tests #11 / Series Builder ReportDefinitionCol renders
[job] [logs] Jest Tests #10 / settings form it show select a connector flyout
[job] [logs] Jest Tests #5 / Sourcerer Hooks does not call addError if updateSourcererDataView receives an AbortError
[job] [logs] Jest Tests #11 / useAggregatedAnomaliesByJob does not throw error when aggregations is undefined
[job] [logs] Jest Tests #11 / useAggregatedAnomaliesByJob returns formated data
[job] [logs] Jest Tests #11 / useAggregatedAnomaliesByJob returns jobs sorted by name
[job] [logs] Jest Tests #4 / useAlertsPrivileges if there is an error when fetching user privilege, we should get back false for all index related properties
[job] [logs] Jest Tests #4 / useAlertsPrivileges returns "hasIndexManage" is false if the privilege does not have cluster manage
[job] [logs] Jest Tests #4 / useAlertsPrivileges returns "hasIndexManage" is true if the privilege has cluster manage
[job] [logs] Jest Tests #4 / useAlertsPrivileges returns "hasKibanaCRUD" as false if user does not have SIEM Kibana "all" privileges
[job] [logs] Jest Tests #4 / useAlertsPrivileges returns "hasKibanaREAD" as false if user does not have at least SIEM Kibana "read" privileges
[job] [logs] Jest Tests #8 / useComparisonCellValue should render a tooltip when the field is derived from a Smart Field
[job] [logs] Jest Tests #16 / useDataGridColumnsCellActions should close popover then action executed
[job] [logs] Jest Tests #16 / useDataGridColumnsCellActions should execute the action with correct context
[job] [logs] Jest Tests #16 / useDataGridColumnsCellActions should execute the action with correct page value
[job] [logs] Jest Tests #8 / useExceptionLists applies filters to query
[job] [logs] Jest Tests #8 / useExceptionLists does not fetch specific list id if it is added to the hideLists array
[job] [logs] Jest Tests #8 / useExceptionLists fetches a new exception list and its items when props change
[job] [logs] Jest Tests #8 / useExceptionLists fetches exception lists
[job] [logs] Jest Tests #8 / useExceptionLists fetches list when refreshExceptionList callback invoked
[job] [logs] Jest Tests #8 / useExceptionLists initializes hook
[job] [logs] Jest Tests #8 / useExceptionLists invokes notifications service if "fetchExceptionLists" fails
[job] [logs] Jest Tests #4 / useFetchAlertData does not populate the results when the request is canceled
[job] [logs] Jest Tests #4 / useFetchAlertData initially is not loading and does not have data
[job] [logs] Jest Tests #4 / useFetchAlertData retrieves the alert data
[job] [logs] Jest Tests #4 / useFetchAlertDetail does not populate the results when the request is canceled
[job] [logs] Jest Tests #4 / useFetchAlertDetail initially is not loading and does not have data
[job] [logs] Jest Tests #4 / useFetchAlertDetail retrieves the alert data
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList fetches the rule with the given ruleId
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when rule api returns an error should call error callback
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule does not have exception list references invokes onSuccess
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule does not have exception list references should update the rule
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule has exception list references and 'detection' is passed in but the rule does not have a reference to 'detection' type exception list should set the exception list to be the newly created list
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule has exception list references and 'detection' is passed in but the rule does not have a reference to 'detection' type exception list should update the rule
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule has exception list references and 'detection' is passed in fetches the exceptions lists
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule has exception list references and 'detection' is passed in invokes onSuccess indicating
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule has exception list references and 'detection' is passed in should set the exception list to be the fetched list
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule has exception list references and 'endpoint' is passed in but the rule does not have a reference to 'endpoint' type exception list should set the exception list to be the newly created list
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule has exception list references and 'endpoint' is passed in but the rule does not have a reference to 'endpoint' type exception list should update the rule
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule has exception list references and 'endpoint' is passed in fetches the exceptions lists
[job] [logs] Jest Tests #5 / useFetchOrCreateRuleExceptionList when the rule has exception list references and 'endpoint' is passed in should set the exception list to be the fetched list
[job] [logs] Jest Tests #16 / useGrouping Renders child component with grouping table wrapper when group is selected
[job] [logs] Jest Tests #16 / useGrouping Renders child component without grouping table wrapper when no group is selected
[job] [logs] Jest Tests #2 / useOnExpandableFlyoutClose should run the callback function and remove the event listener from the window
[job] [logs] Jest Tests #4 / useQueryAlerts fetch alert when index name changed
[job] [logs] Jest Tests #4 / useQueryAlerts fetch alert when query object changed
[job] [logs] Jest Tests #4 / useQueryAlerts fetch alerts data
[job] [logs] Jest Tests #4 / useQueryAlerts if there is an error when fetching data, we should get back the init value for every properties
[job] [logs] Jest Tests #4 / useQueryAlerts init
[job] [logs] Jest Tests #4 / useQueryAlerts re-fetch alerts data
[job] [logs] Jest Tests #4 / useQueryAlerts skip
[job] [logs] Jest Tests #4 / useSignalIndex fetch alerts info
[job] [logs] Jest Tests #4 / useSignalIndex if there is an error during createSignalIndex, we should get back signalIndexExists === false && signalIndexName == null
[job] [logs] Jest Tests #4 / useSignalIndex if there is an error when fetching alerts info, signalIndexExists === false && signalIndexName == null
[job] [logs] Jest Tests #4 / useSignalIndex make sure that createSignalIndex have been called when trying to create signal index
[job] [logs] Jest Tests #4 / useSignalIndex make sure that createSignalIndex is giving back the signal info
[job] [logs] Jest Tests #4 / useSignalIndex should not make API calls when signal index already stored in sourcerer
[job] [logs] Jest Tests #15 / useTimelineEvents Correlation pagination is calling search strategy when switching page
[job] [logs] Jest Tests #15 / useTimelineEvents happy path query
[job] [logs] Jest Tests #15 / useTimelineEvents init
[job] [logs] Jest Tests #15 / useTimelineEvents Mock cache for active timeline when switching page
[job] [logs] Jest Tests #15 / useTimelineEvents should not query again when a field is removed
[job] [logs] Jest Tests #15 / useTimelineEvents should not query again when a removed field is added back
[job] [logs] Jest Tests #15 / useTimelineEvents should query again when a new field is added
[job] [logs] Jest Tests #11 / useTimelineLastEventTime should call search strategy
[job] [logs] Jest Tests #11 / useTimelineLastEventTime should init
[job] [logs] Jest Tests #11 / useTimelineLastEventTime should set response
[job] [logs] Jest Tests #15 / useTimelineTypes timelineFilters set timelineTypes correctly
[job] [logs] Jest Tests #15 / useTimelineTypes timelineTabs set timelineTypes correctly
[job] [logs] Jest Tests #4 / useUserInfo returns default state
[job] [logs] Jest Tests #9 / useWorkpad redirects on alias match
[job] [logs] test/functional/apps/visualize/replaced_vislib_chart_types/config.ts / visualize app - new charts library visualize area charts date histogram when no time filter interval errors should show error when calendar interval invalid
[job] [logs] test/functional/apps/visualize/replaced_vislib_chart_types/config.ts / visualize app - new charts library visualize area charts date histogram when no time filter interval errors should show error when calendar interval invalid
[job] [logs] FTR Configs #1 / visualize app visualize listing page search does not match mid word
[job] [logs] Jest Tests #12 / VisualizeESQL should render the embeddable if no initial input is given
[job] [logs] Jest Tests #12 / VisualizeESQL should run the suggestions api if no initial input is given
[job] [logs] Jest Integration Tests #2 / When using execute action from response actions console should display download link once action completes
[job] [logs] Jest Integration Tests #2 / When using get-file action from response actions console should display download link once action completes
[job] [logs] Jest Integration Tests #2 / When using scan action from response actions console should display action completion info
[job] [logs] Jest Integration Tests #2 / When using the ArtifactListPage component and data exists should show list data loading indicator while list results are retrieved (and after list was checked to see if it has data)
[job] [logs] FTR Configs #9 / X-Pack Accessibility Tests - Group 1 Dashboard controls a11y tests "before all" hook for "Controls main menu panel"

History

💔 Build #233366 failed dc5172b2762f37b19ac8a10a236b3439689a43a4
💔 Build #233356 failed ce09edbca29b6b0909358e85acebe4f7931f9796
💔 Build #232984 failed 489ea243ede54ef6fa41d82b4e2264b304ead406
💔 Build #232737 failed 4504d15682e250001ff3f4cfaa5d5ff2a960dcee

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @eokoneyo

eokoneyo · 2025-01-08T16:57:17Z

Closing this PR as it will not be the one where the migration to React 18 happens

eokoneyo force-pushed the chore/react-upgrade-tryouts branch 2 times, most recently from 3255b42 to 0c906f8 Compare August 29, 2024 07:18

eokoneyo force-pushed the chore/react-upgrade-tryouts branch 3 times, most recently from 2cb879b to d74a297 Compare September 6, 2024 09:48

eokoneyo changed the title ~~upgrade react~~ upgrade to react 18 Sep 6, 2024

eokoneyo self-assigned this Sep 6, 2024

eokoneyo added the Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// label Sep 6, 2024

eokoneyo force-pushed the chore/react-upgrade-tryouts branch 2 times, most recently from 1da14f1 to 0450387 Compare September 9, 2024 09:48

eokoneyo commented Sep 9, 2024

View reviewed changes

packages/kbn-test/src/jest/run.ts Outdated Show resolved Hide resolved

eokoneyo force-pushed the chore/react-upgrade-tryouts branch from 8c2e7b8 to fad261f Compare September 9, 2024 10:53

eokoneyo mentioned this pull request Sep 9, 2024

[React18] upgrade @testing-library/* for react 18 #192354

Closed

eokoneyo force-pushed the chore/react-upgrade-tryouts branch from 4504d15 to 489ea24 Compare September 9, 2024 15:56

eokoneyo added 2 commits September 11, 2024 10:25

upgrade react

a693347

upgrade react-test-renderer

e545073

eokoneyo force-pushed the chore/react-upgrade-tryouts branch from dab05c9 to ce09edb Compare September 11, 2024 08:37

eokoneyo added 3 commits September 11, 2024 16:22

update test snapshots

efcb5f9

fix CI quick checks issues

667cc6a

patch table list view to expose more failing test cases

6537d1d

eokoneyo force-pushed the chore/react-upgrade-tryouts branch from dc5172b to 6537d1d Compare September 11, 2024 14:23

Dosant mentioned this pull request Sep 12, 2024

[React@18 in legacy mode][EuiMemoryTable/EuiSearchBar] Skipped letters while typing elastic/eui#8018

Closed

eokoneyo closed this Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade to react 18#191385

upgrade to react 18#191385
eokoneyo wants to merge 5 commits intoelastic:mainfrom
eokoneyo:chore/react-upgrade-tryouts

eokoneyo commented Aug 27, 2024 •

edited

Loading

Uh oh!

Uh oh!

eokoneyo commented Sep 11, 2024

Uh oh!

eokoneyo commented Sep 11, 2024

Uh oh!

eokoneyo commented Sep 11, 2024

Uh oh!

kibana-ci commented Sep 11, 2024 •

edited

Loading

Uh oh!

eokoneyo commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

eokoneyo commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

Uh oh!

eokoneyo commented Sep 11, 2024

Uh oh!

eokoneyo commented Sep 11, 2024

Uh oh!

eokoneyo commented Sep 11, 2024

Uh oh!

kibana-ci commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

History

Uh oh!

eokoneyo commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eokoneyo commented Aug 27, 2024 •

edited

Loading

kibana-ci commented Sep 11, 2024 •

edited

Loading