[Fleet] Add toggles for agent.monitoring.http.enabled and agent.monitoring.http.buffer.enabled to agent policy advanced settings#190984
Merged
kpollich merged 1 commit intoelastic:mainfrom Aug 21, 2024
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
nchaulet
approved these changes
Aug 21, 2024
Member
nchaulet
left a comment
There was a problem hiding this comment.
LGTM 🚀
Just to check the wanted fields are agent.monitoring.http.enabled and agent.monitoring.http.buffer.enabled ? The PR title do not contains the http part
agent.monitoring.enabled and agent.monitoring.buffer.enabled to agent policy advanced settingsagent.monitoring.http.enabled and agent.monitoring.http.buffer.enabled to agent policy advanced settings
Member
Author
Good catch - I updated the title so the eventual release notes are accurate. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @kpollich |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ref #180922
Re-add the
agent.monitoring.enabledandagent.monitoring.buffer.enabledsettings under Agent Policy -> Advanced Settings.cc @pierrehilbert