Skip to content

[6.x] Making schema async, and plugin discovery expose raw package jsons (#18926)#18940

Merged
kobelb merged 1 commit intoelastic:6.xfrom
kobelb:backport/6.x/pr-18926
May 9, 2018
Merged

[6.x] Making schema async, and plugin discovery expose raw package jsons (#18926)#18940
kobelb merged 1 commit intoelastic:6.xfrom
kobelb:backport/6.x/pr-18926

Conversation

@kobelb
Copy link
Copy Markdown
Contributor

@kobelb kobelb commented May 8, 2018

Backports the following commits to 6.x:

…lastic#18926)

* Making schema async, and plugin discovery expose raw package jsons

* Addressing some peer review comments

* Modifying the way we emit the extendedConfig

* Removing errant config

* Adding filter and last so we only get the last non-null one
@kobelb kobelb added the backport This PR is a backport of another PR label May 8, 2018
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@kobelb
Copy link
Copy Markdown
Contributor Author

kobelb commented May 9, 2018

Jenkins, test this

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@kobelb
Copy link
Copy Markdown
Contributor Author

kobelb commented May 9, 2018

jenkins, test this

I don't understand the CI failures, a yarn install was terminating. NPM's website had some down-time yesterday, but they claim that the repository was up, so that wouldn't explain the failures...

@spalger
Copy link
Copy Markdown
Contributor

spalger commented May 9, 2018

Error: ENOENT: no such file or directory, open '/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/kibana/packages/kbn-plugin-helpers/tasks/build/fixtures/create_build_test_plugin/build/kibana/create_build_test_plugin/node_modules/noop3/factory.js'

Weird...

Received malformed response from registry for undefined. The registry may be down.

Weirder...

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@kobelb
Copy link
Copy Markdown
Contributor Author

kobelb commented May 9, 2018

I found a similar failure on 6.3, so I'm guessing the registry was misbehaving.

@kobelb kobelb merged commit c9cb810 into elastic:6.x May 9, 2018
@kobelb kobelb deleted the backport/6.x/pr-18926 branch May 9, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants