Skip to content

[Security Solution] Integration tests for multi line string field diff algorithm#188688

Merged
dplumlee merged 6 commits intoelastic:mainfrom
dplumlee:multi-line-string-diff-integration-tests
Jul 26, 2024
Merged

[Security Solution] Integration tests for multi line string field diff algorithm#188688
dplumlee merged 6 commits intoelastic:mainfrom
dplumlee:multi-line-string-diff-integration-tests

Conversation

@dplumlee
Copy link
Copy Markdown
Contributor

@dplumlee dplumlee commented Jul 18, 2024 •
edited
Loading

Summary

Completes #180159

Switches fields to use the multi line string diff algorithm assigned to them in the overarching ticket

Adds integration tests in accordance to #188323 for the upgrade/_review API endpoint for the multi line string field diff algorithm.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added test release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area v8.16.0 labels Jul 18, 2024
@dplumlee dplumlee self-assigned this Jul 18, 2024
@dplumlee dplumlee requested a review from a team as a code owner July 18, 2024 18:17
@dplumlee dplumlee requested a review from maximpn July 18, 2024 18:17
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 18, 2024

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 18, 2024

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 18, 2024

Pinging @elastic/security-solution (Team: SecuritySolution)

@dplumlee dplumlee requested review from jpdjere and removed request for maximpn July 18, 2024 18:18
@dplumlee dplumlee mentioned this pull request Jul 18, 2024
Closed
10 tasks
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 18, 2024 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #102 / discover/esql discover esql view filtering by clicking on the table should append an end in existing where clause by clicking the table
  • [job] [logs] Serverless Entity Analytics - Security Cypress Tests #3 / Entity Analytics Dashboard new risk score When risk engine is enabled With host risk data With alerts data filters the alerts count with time range filters the alerts count with time range
  • [job] [logs] Serverless Entity Analytics - Security Cypress Tests #3 / Entity Analytics Dashboard new risk score When risk engine is enabled With user risk data With alerts data filters risk scores with time range filters risk scores with time range
  • [job] [logs] FTR Configs #44 / machine learning - anomaly detection single metric viewer in dashboard with multi metric job should have anomaly click action menu

History

cc @dplumlee

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 18, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6582

[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/management/trial_license_complete_tier/configs/ess.config.ts: 100/100 tests passed.
[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/management/trial_license_complete_tier/configs/serverless.config.ts: 100/100 tests passed.

see run history

@jpdjere
Copy link
Copy Markdown
Contributor

jpdjere commented Jul 23, 2024

@dplumlee Let's merge first #187770 and then we can adapt the FTR tests here to the merged changes.

@dplumlee dplumlee force-pushed the multi-line-string-diff-integration-tests branch from 5360f47 to daa4110 Compare July 25, 2024 20:27
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 25, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

jpdjere
jpdjere approved these changes Jul 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@dplumlee dplumlee merged commit 5817a9c into elastic:main Jul 26, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jul 26, 2024
@dplumlee dplumlee deleted the multi-line-string-diff-integration-tests branch July 26, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jpdjere jpdjere jpdjere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dplumlee dplumlee

Labels

backport:skip This PR does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dplumlee @elasticmachine @kibanamachine @jpdjere @kibana-ci