Skip to content

[8.15] [Security Assistant] Enables automatic setup of Knowledge Base and LangGraph code paths for 8.15 (#188168)#188605

Merged
spong merged 1 commit intoelastic:8.15from
spong:backport/8.15/pr-188168
Jul 17, 2024
Merged

[8.15] [Security Assistant] Enables automatic setup of Knowledge Base and LangGraph code paths for 8.15 (#188168)#188605
spong merged 1 commit intoelastic:8.15from
spong:backport/8.15/pr-188168

Conversation

@spong
Copy link
Copy Markdown
Member

@spong spong commented Jul 17, 2024

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

…ngGraph code paths for `8.15` (elastic#188168)

## Summary

This PR enables the automatic setup of the Knowledge Base and LangGraph
code paths for the `8.15` release. These features were behind the
`assistantKnowledgeBaseByDefault` feature flag, which will remain as a
gate for upcoming Knowledge Base features that were not ready for this
release.

As part of these changes, we now only support the new LangGraph code
path, and so were able to clean up the non-kb and non-RAGonAlerts code
paths. All paths within the `post_actions_executor` route funnel to the
LangGraph implementation.

> [!NOTE]
> We were planning to do the switch to the new
[`chat/completions`](https://github.com/elastic/kibana/pull/184485/files)
public API, however this would've required additional refactoring since
the API's slightly differ. We will make this change and delete the
`post_actions_executor` route for the next release.

### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- Working with docs team to ensure updates before merging, cc
@benironside
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
(cherry picked from commit 661c251)

# Conflicts:
#	.buildkite/ftr_configs.yml
@spong spong added the backport This PR is a backport of another PR label Jul 17, 2024
@spong spong enabled auto-merge (squash) July 17, 2024 21:59
@spong
Copy link
Copy Markdown
Member Author

spong commented Jul 17, 2024

Had to do a manual backport as there were conflicts in .buildkite/ftr_configs.yml. For review, please confirm the only changes here are indeed the removal of the 2 invoke_ai configs.

Copy link
Copy Markdown
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spong spong merged commit 769e980 into elastic:8.15 Jul 17, 2024
@spong spong deleted the backport/8.15/pr-188168 branch July 17, 2024 23:28
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
integrationAssistant 537 536 -1
securitySolution 5608 5607 -1
total -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 16.3MB 16.3MB -5.0KB
Unknown metric groups

ESLint disabled line counts

id before after diff
elasticAssistant 51 48 -3

Total ESLint disabled count

id before after diff
elasticAssistant 51 48 -3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants