Skip to content

[Security Solution] Integration tests for scalar array diff algorithm#187778

Merged
dplumlee merged 6 commits intoelastic:mainfrom
dplumlee:scalar-array-diff-integration-tests
Jul 11, 2024
Merged

[Security Solution] Integration tests for scalar array diff algorithm#187778
dplumlee merged 6 commits intoelastic:mainfrom
dplumlee:scalar-array-diff-integration-tests

Conversation

@dplumlee
Copy link
Copy Markdown
Contributor

@dplumlee dplumlee commented Jul 8, 2024 •
edited
Loading

Summary

Completes #180162

Switches fields to use the scalar array diff algorithms assigned to them in the overarching ticket

Adds integration tests in accordance to #186325 for the upgrade/_review API endpoint for the scalar array diff algorithm.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added test release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area v8.16.0 labels Jul 8, 2024
@dplumlee dplumlee self-assigned this Jul 8, 2024
@dplumlee dplumlee requested a review from a team as a code owner July 8, 2024 16:53
@dplumlee dplumlee requested a review from jpdjere July 8, 2024 16:53
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 8, 2024

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 8, 2024

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 8, 2024

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 8, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6480

[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/management/trial_license_complete_tier/configs/ess.config.ts: 100/100 tests passed.
[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/management/trial_license_complete_tier/configs/serverless.config.ts: 100/100 tests passed.

see run history

@elastic elastic deleted a comment from kibanamachine Jul 9, 2024
@jpdjere jpdjere mentioned this pull request Jul 9, 2024
Closed
10 tasks
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 10, 2024 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests on Serverless #4 / Automated Response Actions From alerts "before all" hook for "should have generated endpoint and rule" "before all" hook for "should have generated endpoint and rule"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #7 / Endpoints page "before all" hook for "Shows endpoint on the list" "before all" hook for "Shows endpoint on the list"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #14 / Response console Execute operations: "before all" hook for ""execute --command" - should execute a command" "before all" hook for ""execute --command" - should execute a command"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #4 / Response console Host Isolation: "before all" hook for "should release an isolated host via response console" "before all" hook for "should release an isolated host via response console"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #5 / Response console Scan operation: "before all" hook for ""scan --path" - should scan a file" "before all" hook for ""scan --path" - should scan a file"

History

cc @dplumlee

@dplumlee dplumlee force-pushed the scalar-array-diff-integration-tests branch from 38625f1 to 074fb00 Compare July 10, 2024 18:17
jpdjere
jpdjere approved these changes Jul 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments! LGTM ✅

@dplumlee dplumlee merged commit 76cc844 into elastic:main Jul 11, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jul 11, 2024
@dplumlee dplumlee deleted the scalar-array-diff-integration-tests branch July 11, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jpdjere jpdjere jpdjere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dplumlee dplumlee

Labels

backport:skip This PR does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dplumlee @elasticmachine @kibanamachine @jpdjere