Skip to content

[Data View Editor] Add rollup deprecation warning#187505

Merged
ElenaStoeva merged 4 commits intoelastic:mainfrom
ElenaStoeva:data-view/rollup-deprecation-warning
Jul 4, 2024
Merged

[Data View Editor] Add rollup deprecation warning#187505
ElenaStoeva merged 4 commits intoelastic:mainfrom
ElenaStoeva:data-view/rollup-deprecation-warning

Conversation

@ElenaStoeva
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva commented Jul 3, 2024

Summary

This PR replaces the Beta callout in the Data view create form with a deprecation callout.

Before:
Screenshot 2024-07-03 at 17 28 35

Now:
Screenshot 2024-07-03 at 17 28 11

How to test:

  1. Start Es and Kibana
  2. Add the sample data "Sample web logs"
  3. Elasticsearch only allows creating a rollup job if there is an existing rollup usage in the cluster. To simulate rollup usage, create a mock rollup index through Console:
PUT /mock_rollup_index
{
  "mappings": {
    "_meta": {
      "_rollup": {
        "id": "logs_job"
      }
    }
  }
}
  1. Create a sample rollup job through Console:
PUT _rollup/job/logs_job
{
  "id": "logs_job",
  "index_pattern": "kibana_sample_data_logs",
  "rollup_index": "rollup_logstash",
  "cron": "* * * * * ?",
  "page_size": 1000,
  "groups": {
    "date_histogram": {
      "interval": "60m",
      "delay": "7d",
      "time_zone": "UTC",
      "field": "@timestamp"
    },
    "terms": {
      "fields": [
        "geo.src",
        "machine.os.keyword"
      ]
    },
    "histogram": {
      "interval": "1003",
      "fields": [
        "bytes",
        "memory"
      ]
    }
  }
}
  1. Delete the mock rollup index since it causes issues for the rollup API that we use to fetch rollup indices:
    DELETE /mock_rollup_index
  2. Navigate to Stack Management -> Data Views and start creating a new data view.
  3. Select the Rollup type.
  4. Verify that the rollup callout is updated.

@ElenaStoeva ElenaStoeva added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes labels Jul 3, 2024
@ElenaStoeva ElenaStoeva self-assigned this Jul 3, 2024
@ElenaStoeva
Copy link
Copy Markdown
Contributor Author

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 3, 2024

💔 Build Failed

Failed CI Steps

History

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva marked this pull request as ready for review July 4, 2024 09:40
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner July 4, 2024 09:40
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

values={{
downsamplingLink: (
<EuiLink
href="https://www.elastic.co/guide/en/elasticsearch/reference/current/downsampling.html"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use docLinks service instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Fixed in 33abfcb

Copy link
Copy Markdown
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ElenaStoeva ElenaStoeva enabled auto-merge (squash) July 4, 2024 13:31
@ElenaStoeva ElenaStoeva merged commit 4e31327 into elastic:main Jul 4, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jul 4, 2024
@ElenaStoeva ElenaStoeva deleted the data-view/rollup-deprecation-warning branch January 31, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants