Merged
Conversation
3e65d29 to
6f49a9b
Compare
f9be5e8 to
c29a5c6
Compare
- requires some amount of type casting, as our theme HOCs sadly do not return class components from the ref
no parameter/fake event needs to be passed, it's optional
- shallow: target the Class now not the HOC'd component - mount: needs to specify `.last()` now because Emotion adds another wrapper to Enzyme, and we want the nested one
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/eui-team (EUI) |
afharo
approved these changes
Jun 26, 2024
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Ikuni17
approved these changes
Jun 26, 2024
peteharverson
approved these changes
Jun 26, 2024
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
ML edit LGTM (gave Import calendar event a visual check).
sebelga
approved these changes
Jun 26, 2024
alisonelizabeth
approved these changes
Jun 26, 2024
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
Management changes lgtm (kbn-management/settings/components/field_input/input/image_input.tsx)
crespocarlos
approved these changes
Jun 26, 2024
nickpeihl
approved these changes
Jun 26, 2024
Contributor
nickpeihl
left a comment
There was a problem hiding this comment.
kibana-gis snapshot change lgtm!
szwarckonrad
approved these changes
Jun 27, 2024
Contributor
szwarckonrad
left a comment
There was a problem hiding this comment.
Tested osquery changes locally, no regression spotted.
👍
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
|
^ Tests are failing on main. Merging this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v95.1.0⏩v95.2.0Questions? Please see our Kibana upgrade FAQ.
v95.2.0EuiContextMenuItemIcon's type definition to explicitly define support forEuiIcon'sIconType(#7804)EuiStepsto support a newtitleSize="xxs"style, which outputs the same title font size but smaller unnumbered step indicators (#7813)EuiStepsHorizontalto support a newsize="xs"style, which outputs smaller unnumbered step indicators (#7813)EuiStepNumberto support newtitleSize="none"which omits rendering step numbers, and will only render icons (#7813)setEuiDevProviderWarningto additionally accept a custom callback function, which warning messages will be passed to (#7820)EuiIconto feature updatedlogoElasticStacklogo for referencing Elastic Stack platform (#7838)EuiIconto feature updatedcasesAppdesign. (#7840)EuiComboBoxto no longer autocomplete searched text when used within forms (#7842)CSS-in-JS conversions
EuiFilePickerto Emotion; Removed$euiFilePickerTallHeight(#7833)