Skip to content

Show _ignored field in Discover#184903

Merged
flash1293 merged 17 commits intoelastic:mainfrom
flash1293:flash1293/ignored_meta_field
Jun 11, 2024
Merged

Show _ignored field in Discover#184903
flash1293 merged 17 commits intoelastic:mainfrom
flash1293:flash1293/ignored_meta_field

Conversation

@flash1293
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 commented Jun 6, 2024

Summary

Closes #184669

To test:

PUT my-ignored-index
{
  "mappings": {
    "properties": {
      "a": {
        "type": "keyword",
        "ignore_above": 10
      }
    }
  }
}

POST my-ignored-index/_doc
{
  "a": "abc"
}

POST my-ignored-index/_doc
{
  "a": "abcabcabcabcabcabcabcabc"
}
Screenshot 2024-06-06 at 10 20 28

@flash1293 flash1293 added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Jun 6, 2024
@ghost
Copy link
Copy Markdown

ghost commented Jun 6, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@flash1293 flash1293 added the Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// label Jun 6, 2024
@flash1293 flash1293 marked this pull request as ready for review June 6, 2024 09:18
@flash1293 flash1293 requested review from a team as code owners June 6, 2024 09:18
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 6, 2024

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta
jughosta approved these changes Jun 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

@flash1293
Copy link
Copy Markdown
Contributor Author

flash1293 commented Jun 6, 2024

/ci

@flash1293 flash1293 requested review from a team as code owners June 6, 2024 15:57
@peteharverson
Copy link
Copy Markdown
Contributor

peteharverson commented Jun 7, 2024

In ML we omit metadata fields in a number of places in our UI. Would you be able to add _ignored into this list:

kibana/x-pack/packages/ml/anomaly_utils/field_types.ts

Line 47 in a03f3bc

export const OMIT_FIELDS: string[] = [

@qn895 we also have that same OMIT_FIELDS list for the data visualizer:

https://github.com/elastic/kibana/blob/main/x-pack/plugins/data_visualizer/common/constants.ts#L54

For consistency, I'm thinking we should add _ignored to that list too, but I can't recall why we don't want to show some of those metadata fields. For example, _ignored seems to be handled OK:

Screenshot 2024-06-07 at 10 36 33

@flash1293
Copy link
Copy Markdown
Contributor Author

flash1293 commented Jun 7, 2024

Thanks @peteharverson - added to the omit array

@jughosta jughosta mentioned this pull request Jun 10, 2024
Closed
10 tasks
jughosta
jughosta reviewed Jun 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully addressed the remaining test failures via flash1293#14

qn895
qn895 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@qn895 qn895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM 🎉

@flash1293
Copy link
Copy Markdown
Contributor Author

flash1293 commented Jun 10, 2024

Wow, thanks a ton, @jughosta - merged it in, let's see whether it works (fingers crossed)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jun 11, 2024

💚 Build Succeeded

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

eokoneyo
eokoneyo approved these changes Jun 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared UX changes LGTM

@flash1293 flash1293 merged commit b757eac into elastic:main Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jughosta jughosta jughosta approved these changes

@markov00 markov00 markov00 approved these changes

@eokoneyo eokoneyo eokoneyo approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Discover: Show _ignored as meta field

9 participants

@flash1293 @elasticmachine @peteharverson @kibana-ci @jughosta @markov00 @eokoneyo @qn895 @kibanamachine