[EuiCheckbox] Remove inList type checkboxes#184881
Merged
cee-chen merged 1 commit intoelastic:mainfrom Jun 7, 2024
Merged
Conversation
- this prop is about to be deprecated shortly by EUI - The same style gets applied when no` label` prop is passed, so no visual regressions should occur
6 tasks
Contributor
Author
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/eui-team (EUI) |
peteharverson
approved these changes
Jun 7, 2024
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
ML changes LGTM
Checked visually the two areas we use this (job selection flyout table; DFA wizard included fields table)
sabarasaba
approved these changes
Jun 7, 2024
Member
sabarasaba
left a comment
There was a problem hiding this comment.
changes lgtm, tested locally
Contributor
Author
|
Thanks y'all, you rock! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
type="inList"prop is about to be deprecated shortly by EUI (elastic/eui#7814), so this is being removed ahead of time. The same style already gets applied when nolabelprop is passed, so no visual regressions should occur (hence the removal of an unnecessary prop).That being said, we would appreciate a quick smoke check of the affected tables by CODEOWNERs to ensure your selection checkboxes look the same as before/unbroken. Thank you!