[Fleet] Fix KQL filtering#183757
Merged
jillguyonnet merged 6 commits intoelastic:mainfrom Jun 18, 2024
Merged
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
6e09c89 to
be5d70e
Compare
Member
Author
|
/ci |
be5d70e to
fb3ad99
Compare
Member
Author
|
/ci |
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Member
Author
|
@elasticmachine merge upstream |
| case `.${FLEET_ENROLLMENT_API_PREFIX}`: | ||
| // Saved Objects are stored in .kibana_ingest. | ||
| // Currently, the search bar is only used to query agent policies. | ||
| case INDEX_NAME: |
Contributor
There was a problem hiding this comment.
nit: INDEX_NAME seems too generic, we could use INGEST_SAVED_OBJECT_INDEX which refers to the same constant.
criamico
approved these changes
Jun 13, 2024
Member
criamico
left a comment
There was a problem hiding this comment.
Thanks for fixing it! LGTM 🚢
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
3 tasks
Member
Author
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #178069
This PR fixes agent policies KQL filtering in Fleet UI. Because agent policy data is retrieved from Saved Objects, the policy fields require the SO prefix (
ingest-agent-policies), which was removed in #161064, to be present (see #178069 (comment) for details). A further ER captures the requirements for displaying custom labels without the prefix.In Fleet UI, the
SearchBarcomponent that uses KQL filtering is used in three tabs:Note that the search inputs in the Uninstall tokens and Data streams tabs are simple text filtering, not KQL.
The filtering behaviour with this fix matches the one in 8.11.0 and is captured in the screen recording below:
policy_idoragent.version)ingest-agent-policies(e.g.ingest-agent-policies.name)nameorpolicy_id)Screen recording
This screen recording shows working KQL filtering and suggestions for the three tabs (fixed for Agent policies):
Screen.Recording.2024-06-11.at.10.27.01.mov
Testing
ingest-agent-policies.name : *agent*should correctly filter for it.Checklist