Skip to content

[8.14] [Security Solution] Timeline : Disabling Timeline ESQL feature flag should disable ESQL Tab. (#182816)#182905

Merged
kibanamachine merged 1 commit intoelastic:8.14from
kibanamachine:backport/8.14/pr-182816
May 8, 2024
Merged

[8.14] [Security Solution] Timeline : Disabling Timeline ESQL feature flag should disable ESQL Tab. (#182816)#182905
kibanamachine merged 1 commit intoelastic:8.14from
kibanamachine:backport/8.14/pr-182816

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

…hould disable ESQL Tab. (elastic#182816)

## Summary

handles elastic#182798

Recently there was PR : elastic#181616
which does not disable ES|QL tab in timeline even if feature flag is
disabled when :
- User has already created a ESQL Query in timeline and saved the
timeline.

This PR makes sure when below feature flag exists, then `ES|QL` tab will
be definitely disabled even when user has a saved timeline with ES|QL
Query in it.

```yaml
xpack.securitySolution.enableExperimental:
  - timelineEsqlTabDisabled

```

## Desk Testing Guidelines

1. Remove above Feature Flag
2. Go to Timeline and Create a Timeline with ESQL Query
3. Save the timeline.
4. Go To advanced Settings and search for `esql` and disable the
`enableESQL` setting.
5. Go back to the timeline saved in step 3.
6. ✅ Assert that the `ES|QL` tab is still there.
7. ✅ Assert that the `ES|QL` tab is NOT there in a new timeline.
8. Add above feature flag - which disables the esql Tab.
9. Go back to the timeline saved in step 3.
10. ✅ Assert that the `ES|QL` tab is no longer there.
11. ✅ Assert that the `ES|QL` tab is NOT there in a new timeline.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit c43da3e)
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / StatusFilter should render

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.2MB 15.2MB +815.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @logeekal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants